GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-139596: Cease caching config.cache & ccache in GH Actions by AA-Turner · Pull Request #139623 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Oct 5, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This removes the config.cache and ccache caches from GitHub Actions. Note that we still install and use ccache via posix-deps-apt.sh, so we will get the benefit from that still (if any), but we will no longer save it to the GHA cache.

A

  • Issue: Caching config.cache in GitHub Actions is unsafe #139596

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
namurphy reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
AA-Turner added 2 commits October 5, 2025 19:42
@AA-Turner
Cease caching config.cache in GH Actions
5c8f6e4
@AA-Turner
Remove ccache action
768faec
@AA-Turner
AA-Turner requested a review from mhsmith October 5, 2025 18:56
@AA-Turner
AA-Turner requested review from ezio-melotti and hugovk as code owners October 5, 2025 18:56
@AA-Turner AA-Turner added the skip news label Oct 5, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 5, 2025
Caching config.cache in GitHub Actions is unsafe #139596
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 5, 2025
@AA-Turner AA-Turner changed the title GH-139596: Cease caching config.cache in GH Actions GH-139596: Cease caching config.cache & ccache in GH Actions Oct 5, 2025
@mhsmith

mhsmith commented Oct 6, 2025

Copy link
Copy Markdown
Member

For future reference:

  • config.cache is removed because Caching config.cache in GitHub Actions is unsafe #139596.
  • ccache is removed because it wasn't giving much benefit, and it may become even less useful when GitHub more strictly enforces the cache size limit.
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhsmith
mhsmith reviewed Oct 6, 2025
View reviewed changes
Comment thread .github/workflows/build.yml
with:
path: config.cache
# Include env.pythonLocation in key to avoid changes in environment when setup-python updates Python
key: ${{ github.job }}-${{ env.IMAGE_OS_VERSION }}-${{ needs.build-context.outputs.config-hash }}-${{ env.pythonLocation }}

@mhsmith mhsmith Oct 6, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also remove config-hash from reusable-context.yml?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@hugovk hugovk Nov 12, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and the config_hash input for some other reusables. Will open a followup.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk hugovk mentioned this pull request Oct 18, 2025
Mark stale prs CI has a very low limit #140279
Closed
@gpshead
Merge branch 'main' into del-config.cache-cache
75bad2e
gpshead
gpshead approved these changes Nov 11, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 11, 2025
@gpshead gpshead added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Nov 11, 2025
@gpshead
gpshead merged commit c744ccb into python:main Nov 11, 2025
52 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Nov 11, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 11, 2025
@miss-islington-app

miss-islington-app Bot commented Nov 11, 2025

Copy link
Copy Markdown

Sorry, @AA-Turner and @gpshead, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c744ccb2c92746bc7be6316ab478dbc13e176e97 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned gpshead Nov 11, 2025
@miss-islington-app

miss-islington-app Bot commented Nov 11, 2025

Copy link
Copy Markdown

Sorry, @AA-Turner and @gpshead, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c744ccb2c92746bc7be6316ab478dbc13e176e97 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead

gpshead commented Nov 11, 2025

Copy link
Copy Markdown
Member

the backport labels were opportunistic checks - actions configs have been rearranged since
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead added a commit to gpshead/cpython that referenced this pull request Nov 11, 2025
@gpshead
[3.14] pythonGH-139596: Cease caching config.cache & ccache in GH Act…
ce5c716 
…ions

Manual redo/backport of python#139623 to 3.14.
@gpshead gpshead mentioned this pull request Nov 11, 2025
[3.14] GH-139596: Cease caching config.cache & ccache in GH Actions #141429
Merged
zware
zware reviewed Nov 11, 2025
View reviewed changes
Comment thread .github/workflows/reusable-wasi.yml
path: ${{ env.CROSS_BUILD_WASI }}/config.cache
# Should be kept in sync with the other config.cache step above.
key: ${{ github.job }}-${{ env.IMAGE_OS_VERSION }}-${{ env.WASI_SDK_VERSION }}-${{ env.WASMTIME_VERSION }}-${{ inputs.config_hash }}-${{ hashFiles('Tools/wasm/wasi/__main__.py') }}-${{ env.pythonLocation }}
run: python3 Tools/wasm/wasi.py make-build-python

@zware zware Nov 11, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a merge misfire:

Suggested change
run: python3 Tools/wasm/wasi.py make-build-python
run: python3 Tools/wasm/wasi make-build-python

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@hugovk hugovk Nov 12, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, will include this in the followup too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk hugovk mentioned this pull request Nov 12, 2025
gh-139596: Cease caching config.cache & ccache in GH Actions #141451
Merged
@hugovk

hugovk commented Nov 12, 2025

Copy link
Copy Markdown
Member

Followup: #141451
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk removed needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Nov 14, 2025
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@AA-Turner @StanFromIreland
pythonGH-139596: Cease caching config.cache & ccache in GH Actions (p…
8a2cb87 
…ythonGH-139623)

* Cease caching config.cache in GH Actions\
* Remove ccache action
@hugovk hugovk mentioned this pull request Jul 5, 2026
GHA: ccache not efficient? #116975
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhsmith mhsmith mhsmith left review comments
@zware zware zware left review comments
@gpshead gpshead gpshead approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@AA-Turner @mhsmith @gpshead @hugovk @zware
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.