GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-139640: Fix swallowing syntax warnings in different modules (restore duplicated PEP 765 warnings) by serhiy-storchaka · Pull Request #139755 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Oct 8, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Revert GH-131993.

Fix swallowing some syntax warnings in different modules if they accidentally have the same message and are emitted from the same line.

  • Issue: Syntax warnings can be swallowed in import #139640

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
serhiy-storchaka requested review from ambv, iritkatriel, lysnikolaou, markshannon and pablogsal as code owners October 8, 2025 07:54
@bedevere-app bedevere-app Bot mentioned this pull request Oct 8, 2025
Syntax warnings can be swallowed in import #139640
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 8, 2025
@serhiy-storchaka

serhiy-storchaka commented Oct 8, 2025

Copy link
Copy Markdown
Member Author

This is a third alternative -- just restore the double PEP 765 warnings. Temporary, I hope.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka changed the title gh-139640: Fix swallowing syntax warnings in different modules gh-139640: Fix swallowing syntax warnings in different modules (restore duplicated PEP 765 warnings) Oct 8, 2025
@serhiy-storchaka serhiy-storchaka mentioned this pull request Oct 8, 2025
gh-131927: Do not emit PEP 765 warnings in ast.parse() #139642
Merged
@serhiy-storchaka
pythongh-139640: Fix swallowing syntax warnings in different modules
c12e7ec 
Revert pythonGH-131993.

Fix swallowing some syntax warnings in different modules if they accidentally
have the same message and are emitted from the same line.
@serhiy-storchaka
serhiy-storchaka force-pushed the compile-syntax-warnings3 branch from 6cb99f0 to c12e7ec Compare October 8, 2025 08:28
@serhiy-storchaka
serhiy-storchaka merged commit 279db6b into python:main Oct 14, 2025
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 14, 2025
@serhiy-storchaka
serhiy-storchaka deleted the compile-syntax-warnings3 branch October 14, 2025 14:48
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label Oct 14, 2025
@miss-islington-app

miss-islington-app Bot commented Oct 14, 2025

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2025
@serhiy-storchaka @miss-islington
pythongh-139640: Fix swallowing syntax warnings in different modules (p…
cd94065 
…ythonGH-139755)

Revert pythonGH-131993.

Fix swallowing some syntax warnings in different modules if they accidentally
have the same message and are emitted from the same line.
(cherry picked from commit 279db6b)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 14, 2025

Copy link
Copy Markdown

GH-140117 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 14, 2025
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 14, 2025
@serhiy-storchaka
[3.13] pythongh-139640: Fix swallowing syntax warnings in different m…
f84e1bd 
…odules (pythonGH-139755)

Revert pythonGH-131993.

Fix swallowing some syntax warnings in different modules if they accidentally
have the same message and are emitted from the same line.
(cherry picked from commit 279db6b)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 14, 2025

Copy link
Copy Markdown

GH-140119 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 14, 2025
@serhiy-storchaka
[3.13] pythongh-139640: Fix swallowing syntax warnings in different m…
72c4058 
…odules (pythonGH-139755)

Revert pythonGH-131993.

Fix swallowing some syntax warnings in different modules if they accidentally
have the same message and are emitted from the same line.

Fix duplicated warnings in the "finally" block.

(cherry picked from commit 279db6b)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Oct 14, 2025
@serhiy-storchaka
[3.13] gh-139640: Fix swallowing syntax warnings in different modules (…
92f7965 
…GH-139755) (GH-140119)

Revert GH-131993.

Fix swallowing some syntax warnings in different modules if they accidentally
have the same message and are emitted from the same line.

Fix duplicated warnings in the "finally" block.

(cherry picked from commit 279db6b)
serhiy-storchaka added a commit that referenced this pull request Oct 14, 2025
@miss-islington @serhiy-storchaka
[3.14] gh-139640: Fix swallowing syntax warnings in different modules (…
af28efd 
…GH-139755) (GH-140117)

Revert GH-131993.

Fix swallowing some syntax warnings in different modules if they accidentally
have the same message and are emitted from the same line.

Fix duplicated warnings in the "finally" block.

(cherry picked from commit 279db6b)

Co-authored-by: Serhiy Storchaka <[email protected]>

* Update 2025-10-06-10-03-37.gh-issue-139640.gY5oTb.rst

---------

Co-authored-by: Serhiy Storchaka <[email protected]>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@serhiy-storchaka @StanFromIreland
pythongh-139640: Fix swallowing syntax warnings in different modules (p…
ea16e4a 
…ythonGH-139755)

Revert pythonGH-131993.

Fix swallowing some syntax warnings in different modules if they accidentally
have the same message and are emitted from the same line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.