GeezerVison

diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
index c14f925b4e7..d2044b55f76 100644
--- a/Modules/_testcapimodule.c
+++ b/Modules/_testcapimodule.c
@@ -2595,6 +2595,80 @@ create_managed_weakref_nogc_type(PyObject *self, PyObject *Py_UNUSED(args))
 }
 
 
+static PyObject *
+bench_dict_new(PyObject *ob, PyObject *args)
+{
+    Py_ssize_t size, loops;
+    if (!PyArg_ParseTuple(args, "nn", &size, &loops)) {
+        return NULL;
+    }
+
+    PyTime_t t1, t2;
+    PyTime_PerfCounterRaw(&t1);
+    for (Py_ssize_t loop=0; loop < loops; loop++) {
+        PyObject *d = PyDict_New();
+        if (d == NULL) {
+            return NULL;
+        }
+
+        for (Py_ssize_t i=0; i < size; i++) {
+            PyObject *key = PyUnicode_FromFormat("%zi", i);
+            assert(key != NULL);
+
+            PyObject *value = PyLong_FromLong(i);
+            assert(value != NULL);
+
+            assert(PyDict_SetItem(d, key, value) == 0);
+            Py_DECREF(key);
+            Py_DECREF(value);
+        }
+
+        assert(PyDict_Size(d) == size);
+        Py_DECREF(d);
+    }
+    PyTime_PerfCounterRaw(&t2);
+
+    return PyFloat_FromDouble(PyTime_AsSecondsDouble(t2 - t1));
+}
+
+
+static PyObject *
+bench_dict_presized(PyObject *ob, PyObject *args)
+{
+    Py_ssize_t size, loops;
+    if (!PyArg_ParseTuple(args, "nn", &size, &loops)) {
+        return NULL;
+    }
+
+    PyTime_t t1, t2;
+    PyTime_PerfCounterRaw(&t1);
+    for (Py_ssize_t loop=0; loop < loops; loop++) {
+        PyObject *d = PyDict_NewPresized(size, 1);
+        if (d == NULL) {
+            return NULL;
+        }
+
+        for (Py_ssize_t i=0; i < size; i++) {
+            PyObject *key = PyUnicode_FromFormat("%zi", i);
+            assert(key != NULL);
+
+            PyObject *value = PyLong_FromLong(i);
+            assert(value != NULL);
+
+            assert(PyDict_SetItem(d, key, value) == 0);
+            Py_DECREF(key);
+            Py_DECREF(value);
+        }
+
+        assert(PyDict_Size(d) == size);
+        Py_DECREF(d);
+    }
+    PyTime_PerfCounterRaw(&t2);
+
+    return PyFloat_FromDouble(PyTime_AsSecondsDouble(t2 - t1));
+}
+
+
 static PyMethodDef TestMethods[] = {
     {"set_errno",               set_errno,                       METH_VARARGS},
     {"test_config",             test_config,                     METH_NOARGS},
@@ -2691,6 +2765,8 @@ static PyMethodDef TestMethods[] = {
     {"toggle_reftrace_printer", toggle_reftrace_printer, METH_O},
     {"create_managed_weakref_nogc_type",
         create_managed_weakref_nogc_type, METH_NOARGS},
+    {"bench_dict_new", bench_dict_new, METH_VARARGS},
+    {"bench_dict_presized", bench_dict_presized, METH_VARARGS},
     {NULL, NULL} /* sentinel */
 };

import pyperf
import _testcapi

runner = pyperf.Runner()
for size in (1, 5, 10, 25, 100, 500, 1_000):
    runner.bench_time_func(f'dict-{size:,}', _testcapi.bench_dict_new, size)

import pyperf
import _testcapi

runner = pyperf.Runner()
for size in (1, 5, 10, 25, 100, 500, 1_000):
    runner.bench_time_func(f'dict-{size:,}', _testcapi.bench_dict_presized, size)

diff --git a/Modules/_testcapi/dict.c b/Modules/_testcapi/dict.c
index 795b2e67b67..90d7c374722 100644
--- a/Modules/_testcapi/dict.c
+++ b/Modules/_testcapi/dict.c
@@ -269,6 +269,113 @@ dict_newpresized(PyObject *self, PyObject *args)
     return PyDict_NewPresized(size, unicode_keys);
 }

+static PyObject *
+bench_dict_newpresized(PyObject *ob, PyObject *args)
+{
+    Py_ssize_t size, loops;
+    if (!PyArg_ParseTuple(args, "nn", &size, &loops)) {
+        return NULL;
+    }
+
+    PyObject **keys = (PyObject **)PyMem_Malloc(size * sizeof(PyObject*));
+    if (keys == NULL) {
+        return NULL;
+    }
+    PyObject **values = (PyObject **)PyMem_Malloc(size * sizeof(PyObject*));
+    if (values == NULL) {
+        return NULL;
+    }
+    for (Py_ssize_t i=0; i < size; i++) {
+        PyObject *key = PyUnicode_FromFormat("%zi", i);
+        assert(key != NULL);
+
+        PyObject *value = PyLong_FromLong(i);
+        assert(value != NULL);
+
+        keys[i] = key;
+        values[i] = value;
+    }
+
+    PyTime_t t1, t2;
+    PyTime_PerfCounterRaw(&t1);
+    for (Py_ssize_t loop=0; loop < loops; loop++) {
+        PyObject *d = PyDict_NewPresized(size, 1);
+        if (d == NULL) {
+            return NULL;
+        }
+
+        for (Py_ssize_t i=0; i < size; i++) {
+            assert(PyDict_SetItem(d, keys[i], values[i]) == 0);
+        }
+
+        assert(PyDict_Size(d) == size);
+        Py_DECREF(d);
+    }
+    PyTime_PerfCounterRaw(&t2);
+
+    for (Py_ssize_t i=0; i < size; i++) {
+        Py_DECREF(keys[i]);
+        Py_DECREF(values[i]);
+    }
+    PyMem_Free(keys);
+    PyMem_Free(values);
+
+    return PyFloat_FromDouble(PyTime_AsSecondsDouble(t2 - t1));
+}
+
+extern PyObject *
+_PyDict_FromItems(PyObject *const *keys, Py_ssize_t keys_offset,
+                  PyObject *const *values, Py_ssize_t values_offset,
+                  Py_ssize_t length);
+
+static PyObject *
+bench_dict_fromitems(PyObject *ob, PyObject *args)
+{
+    Py_ssize_t size, loops;
+    if (!PyArg_ParseTuple(args, "nn", &size, &loops)) {
+        return NULL;
+    }
+
+    PyObject **keys = (PyObject **)PyMem_Malloc(size * sizeof(PyObject*));
+    if (keys == NULL) {
+        return NULL;
+    }
+    PyObject **values = (PyObject **)PyMem_Malloc(size * sizeof(PyObject*));
+    if (values == NULL) {
+        return NULL;
+    }
+    for (Py_ssize_t i=0; i < size; i++) {
+        PyObject *key = PyUnicode_FromFormat("%zi", i);
+        assert(key != NULL);
+
+        PyObject *value = PyLong_FromLong(i);
+        assert(value != NULL);
+
+        keys[i] = key;
+        values[i] = value;
+    }
+
+    PyTime_t t1, t2;
+    PyTime_PerfCounterRaw(&t1);
+    for (Py_ssize_t loop=0; loop < loops; loop++) {
+        PyObject *d = _PyDict_FromItems(keys, 1, values, 1, size);
+        assert(d != NULL);
+        Py_DECREF(d);
+
+    }
+    PyTime_PerfCounterRaw(&t2);
+
+    for (Py_ssize_t i=0; i < size; i++) {
+        Py_DECREF(keys[i]);
+        Py_DECREF(values[i]);
+    }
+    PyMem_Free(keys);
+    PyMem_Free(values);
+
+    return PyFloat_FromDouble(PyTime_AsSecondsDouble(t2 - t1));
+}
+
+

 static PyMethodDef test_methods[] = {
     {"dict_containsstring", dict_containsstring, METH_VARARGS},
@@ -282,6 +389,8 @@ static PyMethodDef test_methods[] = {
     {"dict_popstring_null", dict_popstring_null, METH_VARARGS},
     {"test_dict_iteration", test_dict_iteration, METH_NOARGS},
     {"dict_newpresized", dict_newpresized, METH_VARARGS},
+    {"bench_dict_newpresized", bench_dict_newpresized, METH_VARARGS},
+    {"bench_dict_fromitems", bench_dict_fromitems, METH_VARARGS},