GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-76007: `pydoc`: Catch `DeprecationWarning` for stdlib module `__version__` attributes by StanFromIreland · Pull Request #139997 · python/cpython

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Oct 12, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Misleading __version__ attribute of modules in standard library #76007

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@StanFromIreland
Commit
38f056a
@StanFromIreland
StanFromIreland requested a review from AA-Turner as a code owner October 12, 2025 11:49
@bedevere-app bedevere-app Bot added the awaiting review label Oct 12, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 12, 2025
Misleading __version__ attribute of modules in standard library #76007
Closed
@StanFromIreland
Fix NEWS
cd59287
picnixz
picnixz reviewed Oct 12, 2025
View reviewed changes
Comment thread Lib/pydoc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
Refactor
59e97cb
@StanFromIreland
StanFromIreland requested a review from picnixz October 12, 2025 14:59
picnixz
picnixz reviewed Oct 12, 2025
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some tests for that? (to see that we indeed don't catch the warning)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/pydoc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/pydoc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/pydoc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/pydoc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
Benedikt's review
d17c6ca
@StanFromIreland
StanFromIreland requested a review from picnixz October 13, 2025 09:10
@StanFromIreland
Move basedir default to a class variable
e632008
picnixz
picnixz reviewed Oct 13, 2025
View reviewed changes
Comment thread Lib/test/test_pydoc/test_pydoc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_pydoc/test_pydoc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
Benedikt's review
912c246
@StanFromIreland
StanFromIreland requested a review from picnixz October 13, 2025 10:54
picnixz
picnixz reviewed Oct 13, 2025
View reviewed changes
Comment thread Lib/test/test_pydoc/test_pydoc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_pydoc/test_pydoc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_pydoc/test_pydoc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/pydoc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
Benedikt's review 2.0
9d78fa7
@StanFromIreland
StanFromIreland requested a review from picnixz October 13, 2025 11:16
picnixz
picnixz approved these changes Oct 13, 2025
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll let Adam have a look to see if he wants something different as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 13, 2025
@StanFromIreland

StanFromIreland commented Oct 13, 2025

Copy link
Copy Markdown
Member Author

Renaming MyModule to TestModule? ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz reviewed Oct 13, 2025
View reviewed changes
Comment thread Lib/test/test_pydoc/test_pydoc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland StanFromIreland mentioned this pull request Oct 13, 2025
gh-84232: Fix pydoc docs.python.org link generation #139995
Merged
@StanFromIreland
Add TODO comment, as done in test_code.py
fbaa915
@hugovk
hugovk merged commit 78a50ee into python:main Dec 14, 2025
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 14, 2025
@StanFromIreland
StanFromIreland deleted the pydoc-warnings branch December 14, 2025 13:10
fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 16, 2025
@StanFromIreland @fatelei
pythongh-76007: pydoc: Catch DeprecationWarning for stdlib module…
91f5dfe 
… `__version__` attributes (python#139997)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@StanFromIreland @picnixz @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.