GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-37250: define tp_print for backwards compatibility by jdemeyer · Pull Request #14009 · python/cpython

Conversation

@jdemeyer

@jdemeyer jdemeyer commented Jun 12, 2019 •
edited by vstinner
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

bugfix for 3.8, so needs backport.

https://bugs.python.org/issue37250

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 12, 2019
@bedevere-bot bedevere-bot added the awaiting review label Jun 12, 2019
@mangrisano

mangrisano commented Jun 12, 2019

Copy link
Copy Markdown
Contributor

/cc @vstinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Jun 12, 2019
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cython cannot be fixed instead? I am not sure that I like reintroducing tp_print, it is unused for 10 years...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
asvetlov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@jdemeyer

jdemeyer commented Jun 12, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Cython cannot be fixed instead?

This is being discussed at bpo-37221, please discuss there.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jun 12, 2019

Copy link
Copy Markdown
Member

Please open a separated issue, https://bugs.python.org/issue37221 is about PyCode_New
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jun 12, 2019

Copy link
Copy Markdown
Member

I created https://bugs.python.org/issue37250
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner changed the title bpo-37221: define tp_print for backwards compatibility bpo-37250: define tp_print for backwards compatibility Jun 12, 2019
@jdemeyer
bpo-37250: define tp_print for backwards compatibility
08ed9c7
@jdemeyer
jdemeyer force-pushed the define_tp_print branch from 22d0ccb to 08ed9c7 Compare June 12, 2019 15:09
@jdemeyer

jdemeyer commented Jun 18, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Rejected on bpo-37250
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jdemeyer jdemeyer closed this Jun 18, 2019
@ThomasWaldmann ThomasWaldmann mentioned this pull request Oct 1, 2020
check python 3.9 borgbackup/borg#5372
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jdemeyer @mangrisano @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.