GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-37250: define tp_print for backwards compatibility by jdemeyer · Pull Request #14009 · python/cpython

bpo-37250: define tp_print for backwards compatibility #14009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

jdemeyer wants to merge 1 commit into python:master from jdemeyer:define_tp_print

Uh oh!

There was an error while loading. Please reload this page.

Closed

bpo-37250: define tp_print for backwards compatibility #14009

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

1 commit

Select commit

08ed9c7

bpo-37250: define tp_print for backwards compatibility

jdemeyer Jun 12, 2019

File filter

Filter by extension .c (1) .h (1) .rst (1) All 3 file types selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

4 changes: 4 additions & 0 deletions 4 Include/cpython/object.h

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -174,6 +174,10 @@ typedef struct {
		* backwards-compatibility */
		typedef Py_ssize_t printfunc;

		/* Define tp_print as alias of tp_vectorcall to allow for code accessing
		* this field (hopefully not actually doing anything with it). */
		#define tp_print tp_vectorcall

		typedef struct _typeobject {
		PyObject_VAR_HEAD
		const char tp_name; / For printing, in format "<module>.<name>" */
Expand Down

2 changes: 2 additions & 0 deletions 2 Misc/NEWS.d/next/C API/2019-06-12-11-45-36.bpo-37221.RhP1E7.rst

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		``tp_print`` is defined as alias of ``tp_vectorcall`` to restore support for
		old code (in particular generated by Cython) setting ``tp_print = 0``.

4 changes: 4 additions & 0 deletions 4 Modules/_testcapimodule.c

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -6008,6 +6008,10 @@ PyInit__testcapi(void)
		Py_INCREF(&MyList_Type);
		PyModule_AddObject(m, "MyList", (PyObject *)&MyList_Type);

		/* Old Cython code sets tp_print to 0, we check that
		* this doesn't break anything. */
		MyList_Type.tp_print = 0;

		if (PyType_Ready(&MethodDescriptorBase_Type) < 0)
		return NULL;
		Py_INCREF(&MethodDescriptorBase_Type);
Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.