GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-140257: fix data race on eval_breaker during finalization by ashm-dev · Pull Request #140265 · python/cpython

Conversation

@ashm-dev

@ashm-dev ashm-dev commented Oct 17, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: ThreadSanitizer: data race in interpreter_clear() vs take_gil() during finalization with daemon threads #140257

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ashm-dev
Fix data race on eval_breaker during finalization
626bba4
@ashm-dev
ashm-dev requested review from ZeroIntensity and ericsnowcurrently as code owners October 17, 2025 17:24
@bedevere-app bedevere-app Bot mentioned this pull request Oct 17, 2025
ThreadSanitizer: data race in interpreter_clear() vs take_gil() during finalization with daemon threads #140257
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Oct 17, 2025
@ashm-dev
add blurb
cc0db80
colesbury
colesbury reviewed Oct 17, 2025
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor suggestion on comment including reference to issue

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ashm-dev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Python/pystate.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@colesbury colesbury added the needs backport to 3.14 bugs and security fixes label Oct 17, 2025
@ashm-dev @colesbury
Update Python/pystate.c
059570c 
Co-authored-by: Sam Gross <[email protected]>
@ashm-dev
ashm-dev requested a review from colesbury October 17, 2025 17:57
colesbury
colesbury approved these changes Oct 17, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 17, 2025
kumaraditya303
kumaraditya303 approved these changes Oct 18, 2025
View reviewed changes
@kumaraditya303
kumaraditya303 merged commit c8729c9 into python:main Oct 18, 2025
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Oct 18, 2025

Copy link
Copy Markdown

Thanks @ashm-dev for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 18, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 18, 2025
@ashm-dev @miss-islington
pythongh-140257: fix data race on eval_breaker during finalization (p…
f864c6c 
…ythonGH-140265)

(cherry picked from commit c8729c9)

Co-authored-by: Shamil <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 18, 2025

Copy link
Copy Markdown

GH-140294 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 18, 2025
kumaraditya303 pushed a commit that referenced this pull request Oct 18, 2025
@miss-islington @ashm-dev
[3.14] gh-140257: fix data race on eval_breaker during finalization (G…
3ca7ea1 
…H-140265) (#140294)

gh-140257: fix data race on eval_breaker during finalization (GH-140265)
(cherry picked from commit c8729c9)

Co-authored-by: Shamil <[email protected]>
@ashm-dev
ashm-dev deleted the gh-140257 branch October 19, 2025 20:01
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@ashm-dev @StanFromIreland
pythongh-140257: fix data race on eval_breaker during finalization (p…
4b1a040 
…ython#140265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ashm-dev @colesbury @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.