GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-76007: Deprecate `__version__` attribute in `imaplib` by hugovk · Pull Request #140299 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Oct 18, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Also remove it from the debug output:

         if __debug__:
             self._cmd_log_len = 10
             self._cmd_log_idx = 0
             self._cmd_log = {}           # Last '_cmd_log_len' interactions
             if self.debug >= 1:
-                self._mesg('imaplib version %s' % __version__)
                 self._mesg('new IMAP4 connection, tag=%s' % self.tagpre)

@picnixz Or would you prefer to put the Python version here?

📚 Documentation preview 📚: https://cpython-previews--140299.org.readthedocs.build/

  • Issue: Misleading __version__ attribute of modules in standard library #76007

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Deprecate __version__ attribute in imaplib
b555fb8
@hugovk
hugovk requested review from a team and AA-Turner as code owners October 18, 2025 12:19
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 18, 2025
johnslavik
johnslavik approved these changes Oct 18, 2025
View reviewed changes
@hugovk hugovk changed the title Deprecate __version__ attribute in imaplib gh-76007: Deprecate __version__ attribute in imaplib Oct 18, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 18, 2025
Misleading __version__ attribute of modules in standard library #76007
Closed
@picnixz

picnixz commented Oct 18, 2025

Copy link
Copy Markdown
Member

I think it is fine to remove it. We anyway have a divergence between 3.13 and 3.14 because 3.14 had a new feature and 3.13 and 3.14 had bugfixes that I addes, so it would only help if we had both the version of Python and the IMAP one.

IMO such debugging information could only be useful if the Python version also included the git commit it is based on but that would be an overkill I think.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Oct 18, 2025
View reviewed changes
Comment thread Lib/imaplib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk @vstinner
Fix version number
74b0878 
Co-authored-by: Victor Stinner <[email protected]>
vstinner
vstinner approved these changes Oct 20, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 20, 2025
@hugovk
hugovk merged commit 99c3c63 into python:main Oct 20, 2025
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk deleted the 3.15-deprecate-__version__-imaplib branch October 20, 2025 12:20
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 20, 2025
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@hugovk @vstinner @StanFromIreland
pythongh-76007: Deprecate __version__ attribute in imaplib (pytho…
b40cde6 
…n#140299)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@johnslavik johnslavik johnslavik approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hugovk @picnixz @vstinner @johnslavik
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.