GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||
GeezerVison is showing github.com — gh-76007: Deprecate `__version__` attribute in `decimal` by StanFromIreland · Pull Request #140302 · python/cpython Conversation
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <[email protected]>
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
(Please edit the commit message when merging so that we’re not tagged forever by pushes in clones! thanks 🙂) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: Sergey B Kirpichev <[email protected]>
There was an error while loading. Please reload this page.
Éric, all of my commits up to that point had the commit message "Commit"? I tagged you in the PR description, I don't think that should be a burden for longer than this PR is open? There is an "unsubscribe" button in the right sidebar. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks good, modulo one nitpick about decimal.rst.
I'm not sure also about naming for the constant. But lets see what other people think.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
|
||
| .. versionadded:: 3.8.3 | ||
|
|
||
| .. data:: SPEC_VERSION |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think that this should be moved up before "The constants in this section are only relevant for the C module." sentence of the first paragraph. Which should be also rephrased, i.e. "Following constants in <...>". Clearly, spec version is relevant for both modules.
BTW, I'm not sure about naming. Maybe more verbose "DECIMAL_SPEC_VERSION"?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
BTW, I'm not sure about naming. Maybe more verbose "DECIMAL_SPEC_VERSION"?
I have a similar sentiment, I simply used this since it was in the discussion.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
It seems core devs sometimes use PR descriptions for commit messages. So, it's rather a reminder for one, who will merge this pr. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure also about naming for the constant. But lets see what other people think.
decimal.SPEC_VERSION is fine by me. Skip also suggested it at #76007 (comment).
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <[email protected]>
There was an error while loading. Please reload this page.
|
Merged, thank you. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Oh, importing $ ./python -Werror -c "import decimal" Traceback (most recent call last): File "<string>", line 1, in <module> import decimal File "/home/vstinner/python/main/Lib/decimal.py", line 103, in <module> from _decimal import __version__ # noqa: F401 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ DeprecationWarning: '__version__' is deprecated and slated for removal in Python 3.20 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Oh, ignore my previous comment, I forgot to run |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…n#140302) Co-authored-by: Victor Stinner <[email protected]> Co-authored-by: Sergey B Kirpichev <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.