GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-37223: test_io: silence destructor errors by vstinner · Pull Request #14031 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 12, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue37223

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vstinner added 3 commits June 13, 2019 00:01
@vstinner
bpo-18748: Fix _pyio.IOBase destructor (closed case) (GH-13952)
c7c6582 
_pyio.IOBase destructor now does nothing if getting the closed
attribute fails to better mimick _io.IOBase finalizer.

(cherry picked from commit 4f6f7c5)
@vstinner
bpo-37223: test_io: silence destructor errors (GH-13954)
1a20871 
Implement also MockNonBlockWriterIO.seek() method.

(cherry picked from commit b589cef)
@vstinner
bpo-37223, test_io: silence last 'Exception ignored in:' (GH-14029)
fdc4855 
Use catch_unraisable_exception() to ignore 'Exception ignored in:'
error when the internal BufferedWriter of the BufferedRWPair is
destroyed. The C implementation doesn't give access to the
internal BufferedWriter, so just ignore the warning instead.

(cherry picked from commit 913fa1c)
@vstinner vstinner added the skip news label Jun 12, 2019
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 12, 2019
@bedevere-bot bedevere-bot added the awaiting core review label Jun 12, 2019
@vstinner
vstinner merged commit c15a682 into python:3.8 Jun 12, 2019
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 12, 2019
@vstinner
vstinner deleted the test_io_silence38 branch June 12, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.