GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133656: Remove unused import in `Lib/zipimport.py` by yihong0618 · Pull Request #140325 · python/cpython

Conversation

@yihong0618

@yihong0618 yihong0618 commented Oct 19, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

also drop the import and maybe a tiny performance up(

can skip news

  • Issue: useless code in zipimport can be dropped #140324
  • Issue: Remove deprecated zipimport.zipimporter.load_module #133656

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hyongtao-code reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@yihong0618
fix: drop useless code in zipimport
b252431 
Signed-off-by: yihong0618 <[email protected]>
@yihong0618
yihong0618 requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners October 19, 2025 06:09
@bedevere-app bedevere-app Bot added the awaiting review label Oct 19, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 19, 2025
useless code in zipimport can be dropped #140324
Closed
@StanFromIreland StanFromIreland added the skip news label Oct 19, 2025
@StanFromIreland

StanFromIreland commented Oct 19, 2025

Copy link
Copy Markdown
Member

Last usage was removed in 5c6937a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland
StanFromIreland reviewed Oct 19, 2025
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On lines 13 and 14 we have two commented out imports that exist since the module's Python re-write. I think we can remove them too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@yihong0618
fix: apply comments
b880e3f 
Signed-off-by: yihong0618 <[email protected]>
@yihong0618

yihong0618 commented Oct 19, 2025

Copy link
Copy Markdown
Contributor Author

On lines 13 and 14 we have two commented out imports that exist since the module's Python re-write. I think we can remove them too.

thanks and deleted
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland StanFromIreland changed the title gh-140324: drop useless code in zipimport gh-133656: drop useless code in zipimport Oct 19, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 19, 2025
Remove deprecated zipimport.zipimporter.load_module #133656
Closed
@StanFromIreland StanFromIreland changed the title gh-133656: drop useless code in zipimport gh-133656: Remove unused import in Lib/zipimport.py Oct 19, 2025
brettcannon
brettcannon approved these changes Oct 20, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 20, 2025
@brettcannon
Merge branch 'main' into hy/drop_useless_code_in_zipimport
377d061
@brettcannon
brettcannon enabled auto-merge (squash) October 20, 2025 19:17
@brettcannon
brettcannon disabled auto-merge October 20, 2025 19:17
@brettcannon
brettcannon enabled auto-merge (squash) October 20, 2025 19:17
@brettcannon
brettcannon merged commit d467f24 into python:main Oct 20, 2025
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 20, 2025
@brettcannon

brettcannon commented Oct 21, 2025

Copy link
Copy Markdown
Member

Thanks!
StanFromIreland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@yihong0618 @StanFromIreland
pythongh-133656: Remove unused import and private global in `Lib/zipi…
4b19cb4 
…mport.py` (pythonGH-140325)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments
@brettcannon brettcannon brettcannon approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@yihong0618 @StanFromIreland @brettcannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.