GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-140398: Fix memory leaks in readline module when PySys_Audit fails by ashm-dev · Pull Request #140400 · python/cpython

Conversation

@ashm-dev

@ashm-dev ashm-dev commented Oct 21, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Memory leaks in readline module when PySys_Audit fails #140398

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ashm-dev added 2 commits October 21, 2025 09:18
@ashm-dev
pythongh-140398: Fix memory leaks in readline module when PySys_Audit…
f5453fa 
… fails
@ashm-dev
Create 2025-10-21-09-20-03.gh-issue-140398.SoABwJ.rst
003f29d
@bedevere-app bedevere-app Bot mentioned this pull request Oct 21, 2025
Memory leaks in readline module when PySys_Audit fails #140398
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Oct 21, 2025
kumaraditya303
kumaraditya303 approved these changes Oct 21, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 21, 2025
@kumaraditya303 kumaraditya303 added type-bug An unexpected behavior, bug, or error needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Oct 21, 2025
@kumaraditya303
kumaraditya303 merged commit e8e0f41 into python:main Oct 21, 2025
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 21, 2025
@miss-islington-app

miss-islington-app Bot commented Oct 21, 2025

Copy link
Copy Markdown

Thanks @ashm-dev for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2025
@ashm-dev @miss-islington
pythongh-140398: fix memory leaks in readline module when `PySys_Au…
bf6a37c 
…dit` fails (pythonGH-140400)

(cherry picked from commit e8e0f41)

Co-authored-by: Shamil <[email protected]>
@miss-islington-app

miss-islington-app Bot commented Oct 21, 2025

Copy link
Copy Markdown

Sorry, @ashm-dev and @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e8e0f411bae1dde634fb152a81e1db1ad1cd2eaa 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned kumaraditya303 Oct 21, 2025
@bedevere-app

bedevere-app Bot commented Oct 21, 2025

Copy link
Copy Markdown

GH-140403 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 21, 2025
@ashm-dev
ashm-dev deleted the audit_leak branch October 21, 2025 07:55
kumaraditya303 pushed a commit that referenced this pull request Oct 21, 2025
@miss-islington @ashm-dev
[3.14] gh-140398: fix memory leaks in readline module when `PySys_A…
98d4c21 
…udit` fails (GH-140400) (#140403)

gh-140398: fix memory leaks in `readline` module when `PySys_Audit` fails (GH-140400)
(cherry picked from commit e8e0f41)

Co-authored-by: Shamil <[email protected]>
@StanFromIreland

StanFromIreland commented Oct 27, 2025

Copy link
Copy Markdown
Member

@ashm-dev Can you do the backport please? If you do not know how, let me know and I can do it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ashm-dev

ashm-dev commented Oct 27, 2025

Copy link
Copy Markdown
Contributor Author

@StanFromIreland OK, I'll do it)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ashm-dev added a commit to ashm-dev/cpython that referenced this pull request Oct 27, 2025
@ashm-dev
[3.13] pythongh-140398: fix memory leaks in readline module when `P…
9abb665 
…ySys_Audit` fails (pythonGH-140400)

(cherry picked from commit e8e0f41)

Co-authored-by: Shamil <[email protected]>
@ashm-dev

ashm-dev commented Oct 27, 2025

Copy link
Copy Markdown
Contributor Author

@StanFromIreland This fix does not need to be backported to 3.13 because there were no problems there.
StanFromIreland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland StanFromIreland removed the needs backport to 3.13 only security fixes label Oct 27, 2025
@StanFromIreland

StanFromIreland commented Oct 27, 2025

Copy link
Copy Markdown
Member

Thanks, I removed the back port label.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@ashm-dev @StanFromIreland
pythongh-140398: fix memory leaks in readline module when `PySys_Au…
b072bbf 
…dit` fails (python#140400)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@kumaraditya303 kumaraditya303

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ashm-dev @StanFromIreland @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.