GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — gh-83714: Use "stx_" prefix for all os.statx_result members by vstinner · Pull Request #140432 · python/cpython Conversation
|
|
I'm not convinced that it's a good idea to have It's also strange that some statx members have a I don't think that |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I'm 👍 on this as its evolved. There's too many weird edged cases and just separating entirely makes simpler to reason around.
I think if go forward with this all the stx_ attributes should be explicitly documented rather than refer to stat_result ones of different name. I'm often in a codebase wondering "what is this" and search in page to find; the text note "all the stat members but with a stx_ prefix" would break that
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I think this should list all the attributes now; doc having people translate in their head rather than see "here's the name I used" seems like it will break "search in page" finding the attributes.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Ok, I completed my PR to document all statx_members. It also clarifies which stat_result members are not part of statx_result:
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Rename stx_birthtime to stx_btime, and rename stx_birthtime_ns to stx_btime_ns.
Remove now redundant MEMBER parameter.
|
I updated my PR to document all |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
👍 overall; curious @jbosboom thoughts. Appreciate the fixes/tweaks to Linux kernel version availability.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I changed my mind and just removed the comparison to stat_result:
I don't think that it's useful to compare these two structures, they are different and listing differences is not worth it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I think this needlessly complicates code that uses @vstinner You've made substantial changes to both the interface and implementation of |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Ok, I added myself to the credits. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
…thon#140432) Rename stx_birthtime to stx_btime, and rename stx_birthtime_ns to stx_btime_ns.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.