GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-83714: Only use STATX_MNT_ID & STATX_SUBVOL if they're defined by encukou · Pull Request #140446 · python/cpython

Conversation

@encukou

@encukou encukou commented Oct 22, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add os.statx() function #83714

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
pythongh-83714: Only use STATX_MNT_ID & STATX_SUBVOL if they're defined
e879800
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 22, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 22, 2025
Add os.statx() function #83714
Closed
@encukou encukou added skip news and removed awaiting core review labels Oct 22, 2025
@encukou

encukou commented Oct 22, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64.CentOS9.NoGIL
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 22, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit e879800 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140446%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.CentOS9.NoGIL

The builders matched are:

  • AMD64 CentOS9 NoGIL PR
  • AMD64 CentOS9 NoGIL Refleaks PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Also guard G
f0d5edb
@encukou

encukou commented Oct 22, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64.CentOS9.NoGIL$
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 22, 2025

Copy link
Copy Markdown

The regex 'AMD64.CentOS9.NoGIL$' did not match any buildbot builder. Is the requested builder in the list of stable builders?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Oct 22, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64.CentOS9.NoGIL
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 22, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit f0d5edb 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140446%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.CentOS9.NoGIL

The builders matched are:

  • AMD64 CentOS9 NoGIL PR
  • AMD64 CentOS9 NoGIL Refleaks PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Oct 22, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wrote a similar change before seeing yours :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting merge label Oct 22, 2025
@vstinner

vstinner commented Oct 22, 2025

Copy link
Copy Markdown
Member

Oh sorry, I created a conflict when I merged my other statx() change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Merge in the main branch
0c95f7a
@encukou

encukou commented Oct 22, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64.CentOS9.NoGIL
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 22, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 0c95f7a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140446%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.CentOS9.NoGIL

The builders matched are:

  • AMD64 CentOS9 NoGIL PR
  • AMD64 CentOS9 NoGIL Refleaks PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Oct 22, 2025

Copy link
Copy Markdown
Member Author

Could you please run buildbots for any other statx changes?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit e53e9eb into python:main Oct 22, 2025
6 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou deleted the guard-subvol branch October 22, 2025 10:42
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 22, 2025
@vstinner

vstinner commented Oct 22, 2025

Copy link
Copy Markdown
Member

Could you please run buildbots for any other statx changes?

Ok, I will. We ran buildbots on the change causing the regression, but only some buildbots.
encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@encukou @StanFromIreland
pythongh-83714: Only use STATX_MNT_ID & STATX_SUBVOL if they're defin…
4d159c6 
…ed (pythonGH-140446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@encukou @bedevere-bot @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.