GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-130317: Fix SNaN broken tests on HP PA RISC by stefanor · Pull Request #140452 · python/cpython

Conversation

stefanor commented Oct 22, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

While looking at #140028 I found some unrelated test regressions in the 3.14 cycle. These seem to all come from #130317. From what I can tell, that made Python more correct than it was before. According to 0 HP PA RISC uses 1 for SNaN and thus a 0 for QNaN.

Update tests to expect this.

Issue: struct (un)packing of half-precision nan floats is non-invertible #130317

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fix SNaN broken tests on HP PA RISC

96815eb

While looking at python#140028 I found some unrelated test regressions in the
3.14 cycle. These seem to all come from python#130317. From what I can tell,
that made Python more correct than it was before. According to [0] HP PA
RISC uses 1 for SNaN and thus a 0 for QNaN.

Update tests to expect this.

[0]: https://grouper.ieee.org/groups/1788/email/msg03272.html

bedevere-app Bot added tests

Tests in the Lib/test dir

awaiting review labels

Oct 22, 2025

stefanor commented Oct 22, 2025

Copy link

Copy Markdown

Contributor Author

FYI: @thesamesam

thesamesam reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

skirpichev self-requested a review

October 22, 2025 11:17

skirpichev changed the title ~~Fix SNaN broken tests on HP PA RISC~~ gh-130317: Fix SNaN broken tests on HP PA RISC

Oct 22, 2025

bedevere-app Bot mentioned this pull request

Oct 22, 2025

struct (un)packing of half-precision nan floats is non-invertible #130317

Closed

skirpichev added the skip news label

Oct 22, 2025

skirpichev reviewed

Oct 22, 2025

View reviewed changes

Comment thread

Lib/test/test_capi/test_float.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

skirpichev reviewed

Oct 22, 2025

View reviewed changes

Comment thread

Lib/test/test_struct.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

skirpichev added the needs backport to 3.14 bugs and security fixes label

Oct 22, 2025

skirpichev commented Oct 22, 2025

Copy link

Copy Markdown

Member

CC @vstinner

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Link to wikipedia

210595d

skirpichev approved these changes

Oct 22, 2025

View reviewed changes

skirpichev left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nitpicks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_capi/test_float.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_struct.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added awaiting core review and removed awaiting review labels

Oct 22, 2025


          Tweak comment

5e3b7a9

vstinner approved these changes

Oct 22, 2025

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Oct 22, 2025

vstinner merged commit 76fea55 into python:main

Oct 22, 2025

4 checks passed

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Oct 22, 2025

Copy link

Copy Markdown

Thanks @stefanor for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Oct 22, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 22, 2025


          pythongh-130317: Fix SNaN broken tests on HP PA RISC (pythonGH-140452)

fe6f7fd

While looking at pythonGH-140028, I found some unrelated test regressions in the
3.14 cycle. These seem to all come from pythonGH-130317. From what I can tell,
that made Python more correct than it was before. According to [0], HP PA
RISC uses 1 for SNaN and thus a 0 for QNaN.

[0]: https://grouper.ieee.org/groups/1788/email/msg03272.html
(cherry picked from commit 76fea55)

Co-authored-by: Stefano Rivera <[email protected]>

stefanor deleted the hppa-quiet-nans branch

October 22, 2025 16:36

bedevere-app Bot commented Oct 22, 2025

Copy link

Copy Markdown

GH-140467 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Oct 22, 2025

vstinner commented Oct 22, 2025

Copy link

Copy Markdown

Member

Merged, thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner pushed a commit that referenced this pull request

Oct 22, 2025


          [3.14] gh-130317: Fix SNaN broken tests on HP PA RISC (GH-140452) (#1…

853e5d9

…40467)

gh-130317: Fix SNaN broken tests on HP PA RISC (GH-140452)

While looking at GH-140028, I found some unrelated test regressions in the
3.14 cycle. These seem to all come from GH-130317. From what I can tell,
that made Python more correct than it was before. According to [0], HP PA
RISC uses 1 for SNaN and thus a 0 for QNaN.

[0]: https://grouper.ieee.org/groups/1788/email/msg03272.html
(cherry picked from commit 76fea55)

Co-authored-by: Stefano Rivera <[email protected]>

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request

Dec 6, 2025


          pythongh-130317: Fix SNaN broken tests on HP PA RISC (python#140452)

f839c45

While looking at python#140028, I found some unrelated test regressions in the
3.14 cycle. These seem to all come from python#130317. From what I can tell,
that made Python more correct than it was before. According to [0], HP PA
RISC uses 1 for SNaN and thus a 0 for QNaN.

[0]: https://grouper.ieee.org/groups/1788/email/msg03272.html

Reviewers

vstinner

vstinner approved these changes

skirpichev

skirpichev approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

stefanor commented Oct 22, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stefanor commented Oct 22, 2025

Uh oh!

Uh oh!

Uh oh!

skirpichev commented Oct 22, 2025

Uh oh!

skirpichev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app Bot commented Oct 22, 2025

Uh oh!

bedevere-app Bot commented Oct 22, 2025

Uh oh!

vstinner commented Oct 22, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stefanor commented Oct 22, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.