GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-83714: Set os.statx().stx_mode to None if missing from stx_mask by vstinner · Pull Request #140484 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 22, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Set stx_mode to None if STATX_TYPE|STATX_MODE is missing from stx_mask.
  • Enhance os.statx() tests.
  • statx_result structure: remove atime_sec, btime_sec, ctime_sec and mtime_sec members. Compute them on demand when stx_atime, stx_btime, stx_ctime and stx_mtime are read.
  • Doc: fix statx members sorting.
  • Issue: Add os.statx() function #83714

📚 Documentation preview 📚: https://cpython-previews--140484.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-83714: Set os.statx().stx_mode to None if missing from stx_mask
82a6f31 
* Set stx_mode to None if STATX_TYPE|STATX_MODE is missing from
  stx_mask.
* Enhance os.statx() tests.
* statx_result structure: remove atime_sec, btime_sec, ctime_sec and
  mtime_sec members. Compute them on demand when stx_atime,
  stx_btime, stx_ctime and stx_mtime are read.
* Doc: fix statx members sorting.
@vstinner vstinner added the skip news label Oct 22, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 22, 2025
Add os.statx() function #83714
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 22, 2025
@vstinner

vstinner commented Oct 22, 2025

Copy link
Copy Markdown
Member Author

Another "cleanup" PR for os.statx().

statx_result structure: remove atime_sec, btime_sec, ctime_sec and mtime_sec members. Compute them on demand when stx_atime, stx_btime, stx_ctime and stx_mtime are read.

This might speedup os.statx() calls when these members are not read.

cc @cmaloney @jbosboom

Note for myeslf: This PR should be tested on buildbots before being merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added 3 commits October 22, 2025 23:40
@vstinner
stx_mode getter: remove temporary variable
9291429
@vstinner
Fix missing masks
7ad90a2
@vstinner
tests: be less strict about untested members
f627fcb
@vstinner vstinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 22, 2025
@bedevere-bot

bedevere-bot commented Oct 22, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit f627fcb 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140484%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 22, 2025
@vstinner

vstinner commented Oct 23, 2025

Copy link
Copy Markdown
Member Author

ARM Raspbian Linux Asan PR: test_urllib2net failed (FTP), it's unrelated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Oct 23, 2025

Copy link
Copy Markdown
Member Author

AMD64 Arch Linux buildbots also failed with test_urllib2net.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 5d2edf7 into python:main Oct 23, 2025
70 of 76 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the stx_mode branch October 23, 2025 20:35
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 23, 2025
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@vstinner @StanFromIreland
pythongh-83714: Set os.statx().stx_mode to None if missing from stx_m…
743bd6a 
…ask (python#140484)

* Set stx_mode to None if STATX_TYPE|STATX_MODE is missing from
  stx_mask.
* Enhance os.statx() tests.
* statx_result structure: remove atime_sec, btime_sec, ctime_sec and
  mtime_sec members. Compute them on demand when stx_atime,
  stx_btime, stx_ctime and stx_mtime are read.
* Doc: fix statx members sorting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.