GeezerVison is showing github.com — gh-140544: cleanup `HAVE_THREAD_LOCAL` checks in pystate.c by kumaraditya303 · Pull Request #140547 · python/cpython
Conversation
kumaraditya303
commented
Oct 24, 2025
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
In preparation for storing interpreter state as thread-local variable.
The GIL state functions such as gilstate_get already access _Py_tss_gilstate unconditionally so rather than adding this check everywhere, it is added in the beginning of the file now.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little worried about the rationale expressed in the issue, but I think we should do this anyway.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
corona10 and colesbury reacted with thumbs up emoji
I'm a little worried about the rationale expressed in the issue, but I think we should do this anyway.
Yeah, I feel the same way.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
I'm a little worried about the rationale expressed in the issue, but I think we should do this anyway.
Yeah, this cleanup is orthogonal to the issue but still seems good to clean this up a bit.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
corona10
corona10 approved these changes
ericsnowcurrently
Awaiting requested review from ericsnowcurrently
ericsnowcurrently is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.