GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-139951: Tests on tuple tracking by efimov-mikhail · Pull Request #140575 · python/cpython

Conversation

@efimov-mikhail

@efimov-mikhail efimov-mikhail commented Oct 25, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Since #140262 has been merged, there is no need in this PR #140204.

But I'd like to adapt some tests from that PR for the current implementation.

  • Issue: Potentially serious regression in garbage collector performance in Python 3.14 #139951

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@efimov-mikhail
Tests are added
9900e7b
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Oct 25, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 25, 2025
Potentially serious regression in garbage collector performance in Python 3.14 #139951
Closed
@efimov-mikhail efimov-mikhail added skip news needs backport to 3.14 bugs and security fixes and removed tests Tests in the Lib/test dir awaiting review labels Oct 25, 2025
@efimov-mikhail
efimov-mikhail requested review from sergey-miryanov and vstinner October 25, 2025 10:35
@efimov-mikhail efimov-mikhail mentioned this pull request Oct 25, 2025
gh-139951: Do not track immutable tuples in GC #140204
Closed
sergey-miryanov
sergey-miryanov reviewed Oct 25, 2025
View reviewed changes
Comment thread Lib/test/test_capi/test_tuple.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@efimov-mikhail
Add some comments.
f335ce1
sergey-miryanov
sergey-miryanov approved these changes Oct 27, 2025
View reviewed changes

@sergey-miryanov sergey-miryanov left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
efimov-mikhail reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 27, 2025
@vstinner
vstinner merged commit 88ad41f into python:main Oct 28, 2025
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 28, 2025
@miss-islington-app

miss-islington-app Bot commented Oct 28, 2025

Copy link
Copy Markdown

Thanks @efimov-mikhail for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Oct 28, 2025

Copy link
Copy Markdown

Sorry, @efimov-mikhail and @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 88ad41fa3434444a8f316310bffde50e004156ce 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned vstinner Oct 28, 2025
@vstinner

vstinner commented Oct 28, 2025

Copy link
Copy Markdown
Member

Merged, thanks.

Can you please try to backport your change to 3.14? The automated backport failed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@efimov-mikhail

efimov-mikhail commented Oct 28, 2025

Copy link
Copy Markdown
Member Author

Thx for merge, Victor!
Of course, I'll try to make manual backport.
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
efimov-mikhail added a commit to efimov-mikhail/cpython that referenced this pull request Oct 28, 2025
@efimov-mikhail
pythongh-139951: Tests on tuple GC tracking (python#140575)
4583d27
@bedevere-app

bedevere-app Bot commented Oct 28, 2025

Copy link
Copy Markdown

GH-140701 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 28, 2025
vstinner pushed a commit that referenced this pull request Oct 29, 2025
@efimov-mikhail
[3.14] gh-139951: Tests on tuple GC tracking (GH-140575) (#140701)
8f322ad
@efimov-mikhail
efimov-mikhail deleted the issue-139951-tuple-track-tests branch October 29, 2025 14:39
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@efimov-mikhail @StanFromIreland
pythongh-139951: Tests on tuple GC tracking (python#140575)
241b9aa
@serhiy-storchaka

serhiy-storchaka commented Aug 13, 2026

Copy link
Copy Markdown
Member

This test fails. See #155728.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka mentioned this pull request Aug 13, 2026
test_track_literals depends on a garbage collection #155728
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergey-miryanov sergey-miryanov sergey-miryanov approved these changes
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@efimov-mikhail @vstinner @serhiy-storchaka @sergey-miryanov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.