GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133346: make `_colorize.Argparse` kw-only constructible by picnixz · Pull Request #140620 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Oct 26, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This was an oversight as other themes are kw-only constructible.

  • Issue: Theming support for _colorize #133346

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
add kw_only to _colorize.Argparse dataclass
4e02fb5
@picnixz
picnixz requested a review from hugovk as a code owner October 26, 2025 11:07
@picnixz picnixz added the skip news label Oct 26, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 26, 2025
Theming support for _colorize #133346
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 26, 2025
@picnixz picnixz added the needs backport to 3.14 bugs and security fixes label Oct 26, 2025
@picnixz
picnixz enabled auto-merge (squash) October 26, 2025 11:08
@picnixz picnixz mentioned this pull request Oct 26, 2025
gh-133346: add tests for _colorize.Theme #139687
Merged
@picnixz
picnixz merged commit 387ac2d into python:main Oct 26, 2025
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 26, 2025
@miss-islington-app

miss-islington-app Bot commented Oct 26, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 26, 2025
@picnixz @miss-islington
pythongh-133346: make _colorize.Argparse kw-only constructible (pyt…
9f95ae1 
…honGH-140620)

Other themes are kw-only constructible.
(cherry picked from commit 387ac2d)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 26, 2025

Copy link
Copy Markdown

GH-140621 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 26, 2025
@picnixz
picnixz deleted the fix/colorize/kw-only-dataclass-133346 branch October 26, 2025 11:41
picnixz added a commit that referenced this pull request Oct 26, 2025
@miss-islington @picnixz
[3.14] gh-133346: make _colorize.Argparse kw-only constructible (GH…
d664102 
…-140620) (#140621)

gh-133346: make `_colorize.Argparse` kw-only constructible (GH-140620)

Other themes are kw-only constructible.
(cherry picked from commit 387ac2d)

Co-authored-by: Bénédikt Tran <[email protected]>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@picnixz @StanFromIreland
pythongh-133346: make _colorize.Argparse kw-only constructible (pyt…
c8e88fa 
…hon#140620)

Other themes are kw-only constructible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.