GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-140454: Normalize the JIT stencils filename on Linux to avoid mismatches between the Makefile and the generator by hroncok · Pull Request #140823 · python/cpython

Conversation

@hroncok

@hroncok hroncok commented Oct 31, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This avoids needless JIT recompilation during make install.

  • Issue: 3.15.0a1 rewrites sysconfig-saved flags on make install #140454

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hroncok
pythongh-140454: Generate jit_stencils-*-pc-linux-gnu.h instead of ..…
f5f5274 
….unknown-linux-gnu.h (as expected by Makefile)

This avoids needless JIT recompilation during make install.
@hroncok
hroncok requested review from brandtbucher, diegorusso and savannahostrowski as code owners October 31, 2025 12:23
@bedevere-app bedevere-app Bot mentioned this pull request Oct 31, 2025
3.15.0a1 rewrites sysconfig-saved flags on make install #140454
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Oct 31, 2025
savannahostrowski
savannahostrowski reviewed Nov 2, 2025
View reviewed changes
Comment thread Tools/jit/_targets.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hroncok
Fixup according to review
15b13d5
@hroncok
hroncok requested review from AA-Turner, corona10, emmatyping and erlend-aasland as code owners November 3, 2025 10:55
hroncok added 2 commits November 3, 2025 12:06
@hroncok
fixup! Fixup according to review
35e272c
@hroncok
make regen-configure
f553ad5
savannahostrowski
savannahostrowski approved these changes Nov 4, 2025
View reviewed changes

@savannahostrowski savannahostrowski left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for investigating this and putting up the PR!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hroncok reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 4, 2025
@hroncok hroncok changed the title gh-140454: Generate jit_stencils-*-pc-linux-gnu.h instead of ...unknown-linux-gnu.h (as expected by Makefile) gh-140454: Generate jit_stencils-*-unknown-linux-gnu.h instead of ...-pc-linux-gnu.h (as expected by Makefile) Nov 4, 2025
@hroncok hroncok changed the title gh-140454: Generate jit_stencils-*-unknown-linux-gnu.h instead of ...-pc-linux-gnu.h (as expected by Makefile) gh-140454: Normalize the JIT stencils filename on Linux to avoid mismatches between the Makefile and the generator Nov 4, 2025
@hroncok

hroncok commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

I renamed the PR to match the reality after the fixups. It's still a bit mouthful, feel free to suggest a better commit subject.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@savannahostrowski
savannahostrowski merged commit d5b00c7 into python:main Nov 4, 2025
8 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 4, 2025
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@hroncok @StanFromIreland
pythongh-140454: Normalize the JIT stencils filename on Linux to avoi…
b8539b5 
…d mismatches between the Makefile and the generator (python#140823)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savannahostrowski savannahostrowski savannahostrowski approved these changes
@brandtbucher brandtbucher Awaiting requested review from brandtbucher
@diegorusso diegorusso Awaiting requested review from diegorusso
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hroncok @savannahostrowski
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.