GeezerVison

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

FTR, a buffer underflow is something entirely different.

I have made the requested changes; please review again

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

I have made the requested changes; please review again

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

I have made the requested changes; please review again

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

Aha, I reproduced the ASAN error using ./configure --with-address-sanitizer CC=clang LD=clang and #140594 (comment) reproducer.

$ ./python bug.py 
==3640856==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7ca08c6474ff at pc 0x00000059d67e bp 0x7fff55cd4c50 sp 0x7fff55cd4c48
READ of size 1 at 0x7ca08c6474ff thread T0
    #0 0x00000059d67d in PyOS_StdioReadline /home/vstinner/python/main/Parser/myreadline.c:347:14
    #1 0x00000059d8bf in PyOS_Readline /home/vstinner/python/main/Parser/myreadline.c:411:14
    ...

0x7ca08c6474ff is located 1 bytes before 100-byte region [0x7ca08c647500,0x7ca08c647564)
allocated by thread T0 here:
    #0 0x0000004a8d00 in realloc (/home/vstinner/python/main/python+0x4a8d00) (BuildId: 764499fff4f990ace65f94f78d08a62da34d9197)
    #1 0x00000059d536 in PyOS_StdioReadline /home/vstinner/python/main/Parser/myreadline.c:327:22
    ...
...

Using the ASAN build without the fix, the new test fails as expected:

FAIL: test_null_byte_in_interactive_mode (test.test_cmd_line.CmdLineTest.test_null_byte_in_interactive_mode)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vstinner/python/main/Lib/test/test_cmd_line.py", line 209, in test_null_byte_in_interactive_mode
    self.assertEqual(proc.returncode, 0)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
AssertionError: 1 != 0

Using the ASAN build with the fix, the new test pass as expected.

Thanks @ashm-dev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

Thanks @ashm-dev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

GH-145852 is a backport of this pull request to the 3.14 branch.

GH-145853 is a backport of this pull request to the 3.13 branch.

Thanks @ashm-dev for the fix, I merged your PR and backported the fix to 3.13 and 3.14 branches.