GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-125346: Add more base64 tests by serhiy-storchaka · Pull Request #141061 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Nov 5, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Add more tests for the altchars argument of b64decode() and for the map01 argument of b32decode().

  • Issue: Base64 decode with altchars still accepts non-altchars #125346

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-125346: Add more base64 tests
f922c02 
Add more tests for the altchars argument of b64decode() and for the map01
argument of b32decode().
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Nov 5, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 5, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 5, 2025
Base64 decode with altchars still accepts non-altchars #125346
Closed
@serhiy-storchaka
serhiy-storchaka merged commit 13360ef into python:main Nov 6, 2025
54 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Nov 6, 2025

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 6, 2025
@serhiy-storchaka
serhiy-storchaka deleted the test-base64-decode-altchars branch November 6, 2025 09:34
@miss-islington-app

miss-islington-app Bot commented Nov 6, 2025

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 13360efd385d1a7d0659beba03787ea3d063ef9b 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned serhiy-storchaka Nov 6, 2025
@miss-islington-app

miss-islington-app Bot commented Nov 6, 2025

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 13360efd385d1a7d0659beba03787ea3d063ef9b 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Nov 6, 2025
@serhiy-storchaka
pythongh-141061: Fix decoding with non-standard Base64 alphabet
591127b 
The "+" and "/" characters are no longer recognized as the part of
the Base64 alphabet in base64.urlsafe_b64decode() and base64.b64decode()
the altchars argument that does not contain them.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Nov 6, 2025
@serhiy-storchaka
[3.14] pythongh-125346: Add more base64 tests (pythonGH-141061)
af5c1ae 
Add more tests for the altchars argument of b64decode() and for the map01
argument of b32decode().
(cherry picked from commit 13360ef)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Nov 6, 2025

Copy link
Copy Markdown

GH-141130 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 6, 2025
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.13 only security fixes label Nov 6, 2025
serhiy-storchaka added a commit that referenced this pull request Nov 6, 2025
@serhiy-storchaka
[3.14] gh-125346: Add more base64 tests (GH-141061) (GH-141130)
fd17ee0 
Add more tests for the altchars argument of b64decode() and for the map01
argument of b32decode().
(cherry picked from commit 13360ef)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2025
@serhiy-storchaka @miss-islington
[3.14] pythongh-125346: Add more base64 tests (pythonGH-141061) (pyth…
bc86ae1 
…onGH-141130)

(cherry picked from commit fd17ee0)

Co-authored-by: Serhiy Storchaka <[email protected]>
Add more tests for the altchars argument of b64decode() and for the map01
argument of b32decode().
(cherry picked from commit 13360ef)
serhiy-storchaka added a commit that referenced this pull request Nov 6, 2025
@miss-islington @serhiy-storchaka
[3.13] gh-125346: Add more base64 tests (GH-141061) (GH-141130) (GH-1…
1be80be 
…41133)

(cherry picked from commit fd17ee0)

Add more tests for the altchars argument of b64decode() and for the map01
argument of b32decode().
(cherry picked from commit 13360ef)

Co-authored-by: Serhiy Storchaka <[email protected]>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@serhiy-storchaka @StanFromIreland
pythongh-125346: Add more base64 tests (pythonGH-141061)
b258e33 
Add more tests for the altchars argument of b64decode() and for the map01
argument of b32decode().
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.