GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131498: Remove commented-out dead code in cases_generator/analyzer.py by osamakader · Pull Request #141168 · python/cpython

Conversation

@osamakader

@osamakader osamakader commented Nov 6, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Remove the unused analyze_deferred_refs() function that was completely commented out. This function is not referenced anywhere in the codebase and removing it improves code cleanliness.

  • Issue: Top-of-stack caching in the interpreter #131498

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@osamakader
Remove commented-out dead code in cases_generator/analyzer.py
5d5b7c3
Remove the unused analyze_deferred_refs() function that was completely
commented out. This function is not referenced anywhere in
the codebase and removing it improves code cleanliness.

Signed-off-by: Osama Abdelkader <[email protected]>
@osamakader
osamakader requested a review from markshannon as a code owner November 6, 2025 20:05
@bedevere-app bedevere-app Bot added the awaiting review label Nov 6, 2025
@bedevere-app

This comment was marked as resolved.

Sign in to view
@StanFromIreland StanFromIreland added skip news type-refactor Code refactoring (with no changes in behavior) labels Nov 6, 2025
@StanFromIreland StanFromIreland changed the title Remove commented-out dead code in cases_generator/analyzer.py gh-131498: Remove commented-out dead code in cases_generator/analyzer.py Nov 6, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 6, 2025
Top-of-stack caching in the interpreter #131498
Closed
StanFromIreland
StanFromIreland reviewed Nov 6, 2025
View reviewed changes
Comment thread Tools/cases_generator/analyzer.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@osamakader @StanFromIreland
add new line
056b8e6
Co-authored-by: Stan Ulbrych <[email protected]>
@python-cla-bot

python-cla-bot Bot commented Nov 6, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@osamakader
osamakader requested a review from StanFromIreland November 7, 2025 14:37
@osamakader

osamakader commented Dec 12, 2025

Copy link
Copy Markdown
Contributor Author

@StanFromIreland can you please review?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 1, 2026
@ambv ambv added the needs backport to 3.15 bugs and security fixes label Oct 23, 2026
@ambv
ambv merged commit 1c75034 into python:main Oct 23, 2026
54 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting review label Oct 23, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 23, 2026

Copy link
Copy Markdown

Thanks @osamakader for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app

bedevere-app Bot commented Oct 23, 2026

Copy link
Copy Markdown

GH-160461 is a backport of this pull request to the 3.15 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 23, 2026
ambv pushed a commit that referenced this pull request Oct 23, 2026
@miss-islington @osamakader @StanFromIreland
[3.15] gh-131498: Remove commented-out dead code in cases_generator/a…
c4f6007
…nalyzer.py (GH-141168) (GH-160461)

Remove the unused analyze_deferred_refs() function that was completely
commented out. This function is not referenced anywhere in
the codebase and removing it improves code cleanliness.
(cherry picked from commit 1c75034)

Signed-off-by: Osama Abdelkader <[email protected]>
Co-authored-by: Osama Abdelkader <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news stale Stale PR or inactive for long period of time. type-refactor Code refactoring (with no changes in behavior)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@osamakader @StanFromIreland @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.