GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-141174: Improve `annotationlib.call_annotate_function()` test coverage by dr-carlos · Pull Request #141176 · python/cpython

Conversation

@dr-carlos

@dr-carlos dr-carlos commented Nov 7, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

All lines in call_annotate_function() should now be covered.
This PR includes an added test for call_evaluate_function() as this just calls call_annotate_function() under the hood and some of its code paths weren't being tested.

  • Issue: annotationlib: Improve test coverage #141174

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
dr-carlos added 2 commits November 7, 2025 10:10
@dr-carlos
Test passing unsupported Format values to call_annotate_function()
06d8832
@dr-carlos
Test call_evaluate_function with fake globals that raise errors
3910c6e
@dr-carlos
dr-carlos requested a review from JelleZijlstra as a code owner November 7, 2025 00:00
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Nov 7, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 7, 2025
annotationlib: Improve test coverage #141174
Closed
@JelleZijlstra JelleZijlstra added skip news needs backport to 3.14 bugs and security fixes labels Nov 7, 2025
@JelleZijlstra

JelleZijlstra commented Nov 7, 2025

Copy link
Copy Markdown
Member

One test is failing, could you take a look?
dr-carlos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dr-carlos
Fix typo and comparison in test_fake_global_evaluation
5d60170
@dr-carlos

dr-carlos commented Nov 7, 2025

Copy link
Copy Markdown
Contributor Author

One test is failing, could you take a look?

Fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit 1110e8f into python:main Nov 10, 2025
44 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Nov 10, 2025

Copy link
Copy Markdown

Thanks @dr-carlos for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Nov 10, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2025
@dr-carlos @miss-islington
pythongh-141174: Improve annotationlib.call_annotate_function() tes…
5b7e45e 
…t coverage (pythonGH-141176)

* Test passing unsupported Format values to call_annotate_function()

* Test call_evaluate_function with fake globals that raise errors

* Fix typo and comparison in test_fake_global_evaluation
(cherry picked from commit 1110e8f)

Co-authored-by: dr-carlos <[email protected]>
@bedevere-app

bedevere-app Bot commented Nov 10, 2025

Copy link
Copy Markdown

GH-141355 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 10, 2025
JelleZijlstra pushed a commit that referenced this pull request Nov 10, 2025
@miss-islington @dr-carlos
[3.14] gh-141174: Improve annotationlib.call_annotate_function() te…
4b9ed4e 
…st coverage (GH-141176) (#141355)

gh-141174: Improve `annotationlib.call_annotate_function()` test coverage (GH-141176)

* Test passing unsupported Format values to call_annotate_function()

* Test call_evaluate_function with fake globals that raise errors

* Fix typo and comparison in test_fake_global_evaluation
(cherry picked from commit 1110e8f)

Co-authored-by: dr-carlos <[email protected]>
@dr-carlos
dr-carlos deleted the call-annotate-tests branch November 10, 2025 22:02
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@dr-carlos @StanFromIreland
pythongh-141174: Improve annotationlib.call_annotate_function() tes…
bdb8f67 
…t coverage (python#141176)

* Test passing unsupported Format values to call_annotate_function()

* Test call_evaluate_function with fake globals that raise errors

* Fix typo and comparison in test_fake_global_evaluation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@dr-carlos @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.