GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111389: replace deprecated occurrences of `_PyHASH_*` macros by picnixz · Pull Request #141236 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Nov 8, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Consider restoring _PyHASH_INF/BITS/MODULUS/IMAG as public #111389

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
picnixz requested a review from ericsnowcurrently as a code owner November 8, 2025 12:27
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 8, 2025
@picnixz picnixz added the skip news label Nov 8, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 8, 2025
Consider restoring _PyHASH_INF/BITS/MODULUS/IMAG as public #111389
Closed
@picnixz
use public Py_HASH_* macros in sys.hash_info
b667c2e
@picnixz
picnixz force-pushed the fix/capi/use-public-hash-modulus-111389 branch from 2f8e509 to b667c2e Compare November 8, 2025 12:37
@picnixz
picnixz requested a review from gpshead as a code owner November 8, 2025 12:37
@picnixz picnixz changed the title gh-111389: use public Py_HASH_* macros in sys.hash_info gh-111389: use public Py_HASH_* macros Nov 8, 2025
@picnixz picnixz changed the title gh-111389: use public Py_HASH_* macros gh-111389: replace deprecated occurrences of PyHASH_* macros Nov 8, 2025
@picnixz picnixz changed the title gh-111389: replace deprecated occurrences of PyHASH_* macros gh-111389: replace deprecated occurrences of _PyHASH_* macros Nov 8, 2025
@picnixz picnixz added the type-refactor Code refactoring (with no changes in behavior) label Nov 8, 2025
@picnixz
picnixz requested a review from skirpichev November 8, 2025 12:58
skirpichev
skirpichev approved these changes Nov 8, 2025
View reviewed changes
@picnixz
picnixz merged commit ae1f435 into python:main Nov 9, 2025
46 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 9, 2025
@picnixz
picnixz deleted the fix/capi/use-public-hash-modulus-111389 branch November 9, 2025 14:14
@picnixz

picnixz commented Nov 9, 2025

Copy link
Copy Markdown
Member Author

While I could backport this, I don't think it's worth the effort. This touches code that we usually don't touch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@picnixz @StanFromIreland
pythongh-111389: replace deprecated occurrences of _PyHASH_* macros (…
f617e8b 
…python#141236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichev skirpichev skirpichev approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news type-refactor Code refactoring (with no changes in behavior)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @skirpichev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.