GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116738: Make csv module thread-safe by yoney · Pull Request #141365 · python/cpython

Conversation

@yoney

@yoney yoney commented Nov 10, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Added a critical section to protect the states of ReaderObj and WriterObj in the free-threading build. Without the critical sections, both new free-threading tests were crashing. Also ran the tests with tsan.

cc: @mpage @colesbury

  • Issue: Audit all built-in modules for thread safety #116738

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@yoney
pythongh-116738: Make csv module thread-safe
f14e5fa
@bedevere-app bedevere-app Bot mentioned this pull request Nov 10, 2025
Audit all built-in modules for thread safety #116738
Open
@colesbury colesbury added topic-free-threading needs backport to 3.14 bugs and security fixes labels Nov 10, 2025
@yoney
yoney marked this pull request as ready for review November 10, 2025 17:04
@bedevere-app bedevere-app Bot added the awaiting review label Nov 10, 2025
@colesbury
colesbury requested review from colesbury and mpage November 17, 2025 14:03
colesbury
colesbury approved these changes Nov 21, 2025
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 21, 2025
@colesbury
colesbury merged commit fb26d9c into python:main Nov 21, 2025
56 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 21, 2025
@miss-islington-app

miss-islington-app Bot commented Nov 21, 2025

Copy link
Copy Markdown

Thanks @yoney for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2025
@yoney @miss-islington
pythongh-116738: Make csv module thread-safe (pythongh-141365)
5759304 
Added a critical section to protect the states of `ReaderObj` and `WriterObj` in the free-threading build. Without the critical sections, both new free-threading tests were crashing.
(cherry picked from commit fb26d9c)

Co-authored-by: Alper <[email protected]>
@bedevere-app

bedevere-app Bot commented Nov 21, 2025

Copy link
Copy Markdown

GH-141825 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 21, 2025
colesbury pushed a commit that referenced this pull request Nov 21, 2025
@miss-islington @yoney
[3.14] gh-116738: Make csv module thread-safe (gh-141365) (gh-141825)
af586d8 
Added a critical section to protect the states of `ReaderObj` and `WriterObj` in the free-threading build. Without the critical sections, both new free-threading tests were crashing.
(cherry picked from commit fb26d9c)

Co-authored-by: Alper <[email protected]>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@yoney @StanFromIreland
pythongh-116738: Make csv module thread-safe (pythongh-141365)
2287990 
Added a critical section to protect the states of `ReaderObj` and `WriterObj` in the free-threading build. Without the critical sections, both new free-threading tests were crashing.
ashm-dev pushed a commit to ashm-dev/cpython that referenced this pull request Dec 8, 2025
@yoney @ashm-dev
pythongh-116738: Make csv module thread-safe (pythongh-141365)
5b77088 
Added a critical section to protect the states of `ReaderObj` and `WriterObj` in the free-threading build. Without the critical sections, both new free-threading tests were crashing.
@yoney
yoney deleted the ft_csv branch January 27, 2026 17:07
@hugovk hugovk mentioned this pull request Sep 16, 2026
CPython 3.13-3.15 concurrency and memory-safety issue reports #157601
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@mpage mpage Awaiting requested review from mpage

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@yoney @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.