GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-141553: Fix incorrect function signatures in `_testmultiphase` by ashm-dev · Pull Request #141554 · python/cpython

Conversation

@ashm-dev

@ashm-dev ashm-dev commented Nov 14, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Fix incorrect function signatures in _testmultiphase (UBSan) #141553

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ashm-dev
Fix incorrect function signatures in _testmultiphase
adc184e
@ashm-dev
ashm-dev requested a review from ericsnowcurrently as a code owner November 14, 2025 13:05
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Nov 14, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 14, 2025
Fix incorrect function signatures in _testmultiphase (UBSan) #141553
Closed
@ashm-dev
ashm-dev marked this pull request as draft November 14, 2025 13:05
@bedevere-app bedevere-app Bot removed the awaiting review label Nov 14, 2025
@ashm-dev
fix code
e1e0b00
@ashm-dev
ashm-dev marked this pull request as ready for review November 14, 2025 13:21
@bedevere-app bedevere-app Bot added the awaiting review label Nov 14, 2025
@ashm-dev

ashm-dev commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

I don't think the errors in the UBSAN test are related to this fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303

kumaraditya303 commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

Yes, #141552 will fix it
ashm-dev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ZeroIntensity
ZeroIntensity reviewed Nov 14, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/C_API/2025-11-14-16-02-59.gh-issue-141553.IsXJlH.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity ZeroIntensity added the skip news label Nov 14, 2025
@ashm-dev
remove blurb
838d984
@ashm-dev
ashm-dev requested a review from ZeroIntensity November 14, 2025 14:12
@ashm-dev
Merge branch 'main' into fix/ub-in-_testmultiphase
5033900
picnixz
picnixz reviewed Nov 15, 2025
View reviewed changes
Comment thread Modules/_testmultiphase.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
efimov-mikhail
efimov-mikhail reviewed Nov 15, 2025
View reviewed changes
Comment thread Modules/_testmultiphase.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ashm-dev
Refactor modexport_smoke_free function parameters
587ac0c
@ashm-dev
ashm-dev requested review from efimov-mikhail and picnixz November 15, 2025 13:51
efimov-mikhail
efimov-mikhail approved these changes Nov 15, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Nov 15, 2025
picnixz
picnixz approved these changes Nov 15, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 15, 2025
@picnixz
picnixz merged commit 85f3009 into python:main Nov 15, 2025
52 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 15, 2025
@picnixz

picnixz commented Nov 15, 2025

Copy link
Copy Markdown
Member

Thank you! I think this was introduced in Python 3.15 right?
ashm-dev reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ashm-dev
ashm-dev deleted the fix/ub-in-_testmultiphase branch November 15, 2025 17:47
@ashm-dev

ashm-dev commented Nov 15, 2025

Copy link
Copy Markdown
Contributor Author

Yes, you are right, no backport is needed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@ashm-dev @StanFromIreland
pythongh-141553: Fix incorrect function signatures in `_testmultiphas…
90c2983 
…e` (python#141554)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efimov-mikhail efimov-mikhail efimov-mikhail approved these changes
@picnixz picnixz picnixz approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ashm-dev @kumaraditya303 @picnixz @efimov-mikhail @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.