GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||
GeezerVison is showing github.com — gh-141004: Document soft-deprecated symbols by ZeroIntensity · Pull Request #141634 · python/cpython Conversation
|
Yes. My opinion is that documentation for deprecated API should tell you what to do if you find it in some dusty legacy codebase. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Ok, I can do that. I have a few ideas on how we could format this -- which do you prefer?
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'm not sure that a "Soft-deprecated" section is needed.
That sounds like a reasonable approach. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I'd prefer “Deprecated API” sections at the end of pages. Alas, that might not be a popular preference :(
That makes sense for “close friends” -- e.g. if the porting instructions tell you to use a specific other function instead. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
If others are fine with a Deprecated API section, I would also be fine with it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
See https://docs.python.org/3/c-api/unicode.html#deprecated-api for an example. I think it's working pretty well. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
It looks nice. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Updated, let me know what you think.
In practice, we don't have great replacements for all of these, so I just documented some of them as "do not use". For example, what is a user supposed to do if they find |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
|
Looks good! Hopefully the WG vote will be just a formality. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
There are a couple of APIs on the deprecation list that aren't documented here. I'll address those separately. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…1634) (cherry picked from commit 0e0d51c) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Petr Viktorin <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
|
Sorry, @ZeroIntensity, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-143837 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…GH-143837) gh-141004: Document several soft-deprecated C APIs (GH-141634) (cherry picked from commit 0e0d51c) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Petr Viktorin <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
|
We generally don't deprecate API in released versions, so this shouldn't be backported. That said, I wouldn't revert the 3.14 backport that's already merged. With soft deprecations, there's not much harm done. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…1634) Co-authored-by: Petr Viktorin <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.