GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-129559: Add missing bytearray.resize free threading test by cmaloney · Pull Request #141739 · python/cpython

Conversation

@cmaloney

@cmaloney cmaloney commented Nov 19, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Missed the free threading tests in initial implementation. Running the test under thread sanitizer on a free-threaded build didn't find any issues.

  • Issue: Add bytearray.resize() method #129559

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cmaloney
pythongh-129559: Add missing bytearray.resize free threading test
c92f24b 
Missed the free threading tests in initial implementation. Running the
test under thread sanitizer on a free-threaded build didn't find any issues.
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Nov 19, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 19, 2025
Add bytearray.resize() method #129559
Closed
@cmaloney cmaloney added skip news needs backport to 3.14 bugs and security fixes labels Nov 19, 2025
kumaraditya303
kumaraditya303 approved these changes Nov 21, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 21, 2025
@kumaraditya303
kumaraditya303 merged commit 019c315 into python:main Nov 21, 2025
56 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Nov 21, 2025

Copy link
Copy Markdown

Thanks @cmaloney for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 21, 2025
@miss-islington-app

miss-islington-app Bot commented Nov 21, 2025

Copy link
Copy Markdown

Sorry, @cmaloney and @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 019c315a8e52978da67a3108e441ed5ee376f504 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned kumaraditya303 Nov 21, 2025
@bedevere-bot

bedevere-bot commented Nov 21, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit 019c315.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/12743) and take a look at the build logs.
  4. Check if the failure is related to this commit (019c315) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/12743

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 847, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cmaloney
cmaloney deleted the gh129559_ft branch November 21, 2025 23:00
@bedevere-app

bedevere-app Bot commented Nov 22, 2025

Copy link
Copy Markdown

GH-141835 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 22, 2025
cmaloney added a commit to cmaloney/cpython that referenced this pull request Nov 22, 2025
@cmaloney
[3.14] pythongh-129559: add bytearray.resize thread safety test for…
6e8d127 
… free-threading (pythonGH-141739)

(cherry picked from commit 019c315)

Co-authored-by: Cody Maloney <[email protected]>
kumaraditya303 pushed a commit that referenced this pull request Nov 22, 2025
@cmaloney
[3.14] gh-129559: add bytearray.resize thread safety test for free-…
cfcf765 
…threading (GH-141739) (#141835)

[3.14] gh-129559: add `bytearray.resize` thread safety test for free-threading  (GH-141739)
(cherry picked from commit 019c315)
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@cmaloney @StanFromIreland
pythongh-129559: add bytearray.resize thread safety test for free-t…
ed7b0f4 
…hreading (python#141739)
ashm-dev pushed a commit to ashm-dev/cpython that referenced this pull request Dec 8, 2025
@cmaloney @ashm-dev
pythongh-129559: add bytearray.resize thread safety test for free-t…
3f21052 
…hreading (python#141739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@kumaraditya303 kumaraditya303

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@cmaloney @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.