GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116749: Fix code comment for _PyConfig_GIL_DEFAULT by colesbury · Pull Request #141804 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Nov 20, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Disable GIL by default in free-threaded build #116749

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
Fix code comment for _PyConfig_GIL_DEFAULT
3957c6b
@colesbury colesbury added the skip news label Nov 20, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 20, 2025
Disable the GIL by default in free-threaded builds #116329
Closed
@colesbury
colesbury marked this pull request as ready for review November 20, 2025 19:24
@colesbury
colesbury requested a review from ericsnowcurrently as a code owner November 20, 2025 19:24
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 20, 2025
@colesbury
colesbury requested a review from encukou November 20, 2025 19:24
ayushHardeniya
ayushHardeniya approved these changes Nov 20, 2025
View reviewed changes

@ayushHardeniya ayushHardeniya left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
encukou
encukou approved these changes Nov 24, 2025
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Process nitpick: It would be nice to group this with the actual code change. Consider amending the title of gh-116749, attaching this PR to that, and marking gh-116329 as duplicate.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
colesbury reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 24, 2025
@colesbury colesbury changed the title gh-116329: Fix code comment for _PyConfig_GIL_DEFAULT gh-116749: Fix code comment for _PyConfig_GIL_DEFAULT Nov 24, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 24, 2025
Disable GIL by default in free-threaded build #116749
Closed
@colesbury
colesbury merged commit c490ffb into python:main Nov 24, 2025
52 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
colesbury deleted the _PyConfig_GIL_DEFAULT branch November 24, 2025 15:42
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 24, 2025
@colesbury colesbury added the needs backport to 3.14 bugs and security fixes label Nov 24, 2025
@miss-islington-app

miss-islington-app Bot commented Nov 24, 2025

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2025
@colesbury @miss-islington
pythongh-116749: Fix code comment for _PyConfig_GIL_DEFAULT (pythongh…
927ebe5 
…-141804)

(cherry picked from commit c490ffb)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app

bedevere-app Bot commented Nov 24, 2025

Copy link
Copy Markdown

GH-141911 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 24, 2025
colesbury added a commit that referenced this pull request Nov 24, 2025
@miss-islington @colesbury
[3.14] gh-116749: Fix code comment for _PyConfig_GIL_DEFAULT (gh-141804…
cabaa47 
…) (gh-141911)

(cherry picked from commit c490ffb)

Co-authored-by: Sam Gross <[email protected]>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@colesbury @StanFromIreland
pythongh-116749: Fix code comment for _PyConfig_GIL_DEFAULT (pythongh…
16cc2b2 
…-141804)
ashm-dev pushed a commit to ashm-dev/cpython that referenced this pull request Dec 8, 2025
@colesbury @ashm-dev
pythongh-116749: Fix code comment for _PyConfig_GIL_DEFAULT (pythongh…
5a8eb3e 
…-141804)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
+1 more reviewer
@ayushHardeniya ayushHardeniya ayushHardeniya approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@colesbury @encukou @ayushHardeniya
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.