GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119786: Remove mention of `_PyThreadState_BumpFramePointer` from `InternalDocs/interpreter.md` by efimov-mikhail · Pull Request #141816 · python/cpython

Conversation

@efimov-mikhail

@efimov-mikhail efimov-mikhail commented Nov 21, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

In #93908 function _PyThreadState_BumpFramePointer was removed.
But we still have its mention in InternalDocs/interpreter.md.
I propose to remove it and slightly change wording around.
For example, functions _PyThreadState_HasStackSpace and _PyFrame_PushUnchecked could be mentioned.

CC @iritkatriel @markshannon

  • Issue: create an internals documentation folder in the cpython repo #119786

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@efimov-mikhail
Remove mention of _PyThreadState_BumpFramePointer
bbe6b3d
@efimov-mikhail
efimov-mikhail requested a review from AA-Turner as a code owner November 21, 2025 08:55
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 21, 2025
@github-project-automation github-project-automation Bot added this to Docs PRs Nov 21, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Nov 21, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 21, 2025
create an internals documentation folder in the cpython repo #119786
Closed
@efimov-mikhail
efimov-mikhail requested review from iritkatriel and markshannon and removed request for AA-Turner November 21, 2025 08:55
iritkatriel
iritkatriel reviewed Nov 21, 2025
View reviewed changes
Comment thread InternalDocs/interpreter.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@efimov-mikhail @iritkatriel
Update InternalDocs/interpreter.md
7c78bb1 
Co-authored-by: Irit Katriel <[email protected]>
@efimov-mikhail
efimov-mikhail requested a review from iritkatriel November 21, 2025 11:02
iritkatriel
iritkatriel approved these changes Nov 21, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 21, 2025
@iritkatriel

iritkatriel commented Nov 21, 2025

Copy link
Copy Markdown
Member

how far back does this needs back porting?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@efimov-mikhail efimov-mikhail added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Nov 21, 2025
@efimov-mikhail

efimov-mikhail commented Nov 21, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Thx for the review, @iritkatriel!

Backporting to 3.13 and 3.14 seems to be optimal, since this change was landed to 3.12, and docs changes are definitely not a security fixes.
I've added those labels.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented Nov 21, 2025

Copy link
Copy Markdown
Member

we can back port doc updates to security fix versions
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@efimov-mikhail efimov-mikhail removed the needs backport to 3.13 only security fixes label Nov 21, 2025
@efimov-mikhail

efimov-mikhail commented Nov 21, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Actually, we can backport only to 3.14, since there's no InternalDocs/interpreter.md file on 3.13.
I forgot about it, sorry.
sergey-miryanov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sergey-miryanov
sergey-miryanov approved these changes Nov 21, 2025
View reviewed changes
@hugovk
hugovk merged commit cf7a309 into python:main Dec 16, 2025
38 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Dec 16, 2025
@miss-islington-app

miss-islington-app Bot commented Dec 16, 2025

Copy link
Copy Markdown

Thanks @efimov-mikhail for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 16, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2025
@efimov-mikhail @iritkatriel @miss-islington
pythongh-119786: Remove mention of _PyThreadState_BumpFramePointer …
7d0cb9b 
…from `InternalDocs/interpreter.md` (pythonGH-141816)

(cherry picked from commit cf7a309)

Co-authored-by: Mikhail Efimov <[email protected]>
Co-authored-by: Irit Katriel <[email protected]>
@bedevere-app

bedevere-app Bot commented Dec 16, 2025

Copy link
Copy Markdown

GH-142812 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Dec 16, 2025
hugovk pushed a commit that referenced this pull request Dec 16, 2025
@miss-islington @efimov-mikhail @iritkatriel
[3.14] gh-119786: Remove mention of _PyThreadState_BumpFramePointer…
6545f24 
… from `InternalDocs/interpreter.md` (GH-141816) (#142812)

Co-authored-by: Mikhail Efimov <[email protected]>
Co-authored-by: Irit Katriel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergey-miryanov sergey-miryanov sergey-miryanov approved these changes
@iritkatriel iritkatriel iritkatriel approved these changes
@markshannon markshannon Awaiting requested review from markshannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@efimov-mikhail @iritkatriel @sergey-miryanov @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.