GeezerVison is showing github.com — gh-138122: Add thread status statistics to flamegraph profiler by pablogsal · Pull Request #141900 · python/cpython
Conversation
pablogsal
commented
Nov 24, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
The flamegraph profiler now collects thread state information (GIL held, GIL released, waiting for GIL, and garbage collection activity) during sampling and displays it in an interactive statistics bar. This helps users identify GIL contention and understand thread behavior patterns.
Statistics are calculated both in aggregate and per-thread. When filtering the flamegraph to a specific thread, the display updates to show that thread's metrics. In GIL-only profiling mode, GIL-related statistics are hidden since they aren't meaningful in that context.
Per-thread GC percentages now use total samples as the denominator instead of per-thread sample counts. This makes them directly comparable with aggregate statistics and easier to interpret when threads appear in different numbers of samples.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dolfinus and ermakov-oleg reacted with rocket emoji
…raph profiler
The flamegraph profiler now collects thread state information (GIL held,
GIL released, waiting for GIL, and garbage collection activity) during
sampling and displays it in an interactive statistics bar. This helps users
identify GIL contention and understand thread behavior patterns.
Statistics are calculated both in aggregate and per-thread. When filtering
the flamegraph to a specific thread, the display updates to show that
thread's metrics. In GIL-only profiling mode, GIL-related statistics are
hidden since they aren't meaningful in that context.
The collection logic was refactored to process each sample in a single pass
rather than iterating through threads multiple times. GC frame detection now
uses a shared helper that consistently handles both tuple and object frame
formats.
Per-thread GC percentages now use total samples as the denominator instead
of per-thread sample counts. This makes them directly comparable with
aggregate statistics and easier to interpret when threads appear in different
numbers of samples.
The JavaScript includes null checks for DOM access and validates data
availability before rendering. Tests verify the JSON structure, percentage
calculations, and edge cases like zero samples, using only public APIs.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! One small thing: for the percentages in the thread-stats-bar, maybe we should use the same rounding as the flamegraph nodes so everything is consistent.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|