GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-1025395: Fix email.utils.parseaddr to handle multiple hops by ioanatia · Pull Request #142 · python/cpython

Conversation

ioanatia commented Feb 17, 2017 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

This fixes a very old issue with email.utils.parseaddr.
Right now email.utils.parseaddr will fail to parse the input correctly when the address contains a route with multiple hops. However it does not have an issue with single hop routes.

RFC5322 states that including route hops is obsolete and that the route part should be ignored (Section 4.4). It also states that this syntax is valid and it must be accepted and parsed (Section 4).

https://bugs.python.org/issue1025395

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fteem reacted with hooray emoji

All reactions

🎉 1 reaction

the-knights-who-say-ni commented Feb 17, 2017

Copy link

Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

If you don't have an account on b.p.o, please create one
Make sure your GitHub username is listed in "Your Details" at b.p.o
If you have not already done so, please sign the PSF contributor agreement
If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

the-knights-who-say-ni added the CLA not signed label

Feb 17, 2017

Mariatta removed the CLA not signed label

Feb 18, 2017

the-knights-who-say-ni added the CLA signed label

Feb 18, 2017

serhiy-storchaka closed this

Oct 24, 2017

serhiy-storchaka reopened this

Oct 24, 2017

serhiy-storchaka mentioned this pull request

Oct 27, 2017

The PR is blocked by the issue-number check python/core-workflow#199

Closed

ioanatia force-pushed the fix-email-utils-parseaddr branch from 350ccc1 to 9804620 Compare

October 27, 2017 15:50

ioanatia requested a review from a team as a code owner

October 27, 2017 15:50

brettcannon closed this

Oct 27, 2017

brettcannon reopened this

Oct 27, 2017

akruis pushed a commit to akruis/cpython that referenced this pull request

Nov 7, 2017


          Stackless issue python#142: Update URLs

4fc14c7

Update the URLs for the documentation (http://stackless.readthedocs.io)
and source code browsing (https://github.com/stackless-dev/stackless).
(cherry picked from commit b4a5725)

ioanatia commented Nov 7, 2017

Copy link

Copy Markdown

Author

Hey folks! I was wondering why my PR keeps failing, even though I did a rebase a couple of days ago! Can someone elucidate what might be going on here, please? From what I'm noticing, the Travis job has a different config than other jobs, so I'm kinda confused about why is that. Thanks a lot!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brettcannon commented Nov 7, 2017

Copy link

Copy Markdown

Member

It's totally fine to just do a merge if that's easier since we will do a squash commit in the end. I've restarted the Travis job just in case it was a weird fluke, though.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ioanatia force-pushed the fix-email-utils-parseaddr branch from 9804620 to 6d17d16 Compare

December 8, 2017 14:32

ioanatia commented Dec 8, 2017

Copy link

Copy Markdown

Author

Rebasing the branch on latest master does not fix it.
It seems to be that the travis build is not even run my latest commit, but on a random one de1d4fc .
On the other hand, the appveyor build seems fine.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brettcannon commented Dec 8, 2017

Copy link

Copy Markdown

Member

Maybe try doing a merge instead of a rebase? We've had issues in the past of Travis only grabbing the last 50 commits so that can lead to issues with older PRs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brettcannon added the awaiting review label

Feb 21, 2018

akruis pushed a commit to akruis/cpython that referenced this pull request

Mar 25, 2018


          Stackless issue python#142: Update URLs

b4a5725

Update the URLs for the documentation (http://stackless.readthedocs.io)
and source code browsing (https://github.com/stackless-dev/stackless).

Mariatta commented May 15, 2018

Copy link

Copy Markdown

Member

Thanks for the PR, @ioanatia.

Travis build failed:

/home/travis/build/python/cpython/Doc/library/pyexpat.rst:872:Footnote [#] is not referenced.

The change seems unrelated to your change, but unless that got fixed we can't accept the PR.

I realize this PR is quite old, so it's possible the fix for the failed travis build has already been done.
Will it be possible to rebase it off the latest master branch? If it's easier feel free to open a new PR.

Please add yourself to Misc/ACKs file (there's a brief info about that here
Please add a news entry describing this change. It can be added using blurb add.

The instruction for blurb add is here
There are additional details about how to write the news entry here
blurb is available in python >= 3.5

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mariatta requested changes

May 16, 2018

View reviewed changes

Mariatta left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my review: #142 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot commented May 16, 2018

Copy link

Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting changes and removed awaiting review labels

May 16, 2018


          Fix email.utils.parseaddr to handle multiple hops

4194c66

ioanatia force-pushed the fix-email-utils-parseaddr branch from 8219850 to 4194c66 Compare

May 16, 2018 18:18

ioanatia mentioned this pull request

May 16, 2018

bpo-1025395: Fix email.utils.parseaddr to handle multiple hops #6917

Closed

ioanatia commented May 16, 2018

Copy link

Copy Markdown

Author

thanks @Mariatta !
I rebased this branch on latest master multiple times, but somehow the Travis build seems to pick up the same unrelated commit de1d4fc .

Not sure what else I can do than to close this one and reopen it in #6917.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ioanatia closed this

May 16, 2018

akruis pushed a commit to akruis/cpython that referenced this pull request

Jun 19, 2018


          Stackless issue python#142: Update URLs

2dbdb1e

Update the URLs for the documentation (http://stackless.readthedocs.io)
and source code browsing (https://github.com/stackless-dev/stackless).
(cherry picked from commit b4a5725)

bedevere-app Bot mentioned this pull request

Aug 25, 2024

email.Utils.parseaddr fails to parse valid addresses #40889

Open

SonicField added a commit to SonicField/cpython that referenced this pull request

Apr 26, 2026


          docs: W-PROTOCOL-CODIFY P8/P9/P10 codification

ad08ff0

Codifies three protocols developed across the emitAnyCall PURE conversion
arc (push 56-59) per pythia python#142/python#141/python#143 + supervisor + theologian
authorizations:

P8 — Phase 0' Coverage Extension to Perf-Regressing Benchmarks
Per pythia python#142 python#1 + supervisor 22:46:24Z + 22:47:40Z. Sentinel-only HIR
diff has empirical blind spot to single-bench regressions on unrelated
workloads (caught when emitAnyCall push 59 showed int_arith -10% with
exception-sentinel HIR-diff PASSING). Procedure: identify 24-bench >5%
benches, run Phase 0' HIR-diff on bench source per identified bench
(precise scrub, structural diff). Add to gate Step 7 post-processing.

P9 — Filesystem-First Cross-Check Before Fabrication HALT
Per medic 2026-04-22 build-claim false positive + medic 2026-04-25
22:50:53Z PYTHONJITDUMPFINALHIR false positive against generalist HIR
dumps that were filesystem-verified at /tmp + retracted at 22:53:44Z.
Procedure: identify implied artifact, ls + stat to confirm
existence/mtime, post QUERY (not HALT) if artifact exists, never cite
session-log absence as sole evidence. Costs ~30s vs ~5-10min false-
positive recovery cycle.

P10 — Variance Characterization Before (B) Investigation
Per W-EMITANYCALL-INT-ARITH-PERF closure 22:57:29Z + pythia python#143 python#1
amendment 23:21:18Z + supervisor 23:21:51Z. Mirrors agent-memory
feedback_falsifier_convergent_negative.md (per-agent reasoning side);
P10 codifies team-process side. Procedure (7 steps): identify >5%
benches, 3-run targeted re-runs for in-isolation variance, AT LEAST ONE
full-24-bench re-run for in-context variance (different statistical
populations: page-cache, branch-predictor, allocator history,
subprocess-position effects). Closure REQUIRES both isolated AND
in-context corroboration; if isolated clean but in-context reproduces
delta → real signal in sequence-context layer (cold-start/page-cache),
not at conversion layer.

Pythia python#143 python#4 caught these 3 protocols as 'LANDED in spec but
uncommitted at HEAD 0810be4 — exist only in working tree, not yet
history.' This commit closes that gap: protocols now in git history
before being cited as canonical (CC3 codification-on-authoring rule).

Spec doc: P1-P10 + 3 cross-cutting (CC1/CC2/CC3) + paired empirical
controls (PhxMem positive / HirType negative).

Bundle target: push 60 if Alex authorizes (A)/(B)/(C); separate
codification push if Alex direction is delayed >2hr per supervisor
23:21:51Z.

Reviewers

Mariatta

Mariatta requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ioanatia commented Feb 17, 2017 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Feb 17, 2017

Uh oh!

ioanatia commented Nov 7, 2017

Uh oh!

brettcannon commented Nov 7, 2017

Uh oh!

ioanatia commented Dec 8, 2017

Uh oh!

brettcannon commented Dec 8, 2017

Uh oh!

Mariatta commented May 15, 2018

Uh oh!

Mariatta left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented May 16, 2018

Uh oh!

ioanatia commented May 16, 2018

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ioanatia commented Feb 17, 2017 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.