GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||
GeezerVison is showing github.com — gh-141770: Annotate anonymous mmap usage if "-X dev" is used by corona10 · Pull Request #142079 · python/cpython Conversation
|
Annotation
Without annotation
I verified that this annotation actually works, and I believe it will be very helpful for debugging when needed. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
cc @picnixz |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
FYI, Fedora does not support yet even if the kernel version itself already support it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Bénédikt Tran <[email protected]>
There was an error while loading. Please reload this page.
|
FWIW, it would be useful to have an option to enable this in release builds too. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@SpecLad Thanks for the feedback, I will create a separate PR :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@SpecLad Just out of curiosity, passing the build flag through |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
To be clear, by "option" I really mean a runtime option. 🙂 It would be pretty annoying to have to rebuild Python just for this. If you compare with other implementations, none of them require a compile-time option:
TBH, I don't see why Python shouldn't also permanently enable this, but I would settle for "off by default, enabled with environment variable or |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It's a bit annoying that this would only be supported on Linux. Do we have an option that isn't supported everywhere? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| modules that are missing or packaged separately. | ||
| (Contributed by Stan Ulbrych and Petr Viktorin in :gh:`139707`.) | ||
|
|
||
| * Annotating anonymous mmap usage is now supported if Linux kernel supports ``PR_SET_VMA_ANON_NAME`` (Linux 5.17 or newer). |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
* Annotating anonymous mmap usage is now supported if Linux kernel
supports :manpage:`PR_SET_VMA_ANON_NAME <PR_SET_VMA(2const)>`
(Linux 5.17 or newer).I don't know under which manpage entry it is, but if you locally run Sphinx, you should be able to find the correct one. That way, users would have a link to click on. If there isn't a manpage, nevermind.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
…e-141770.JURnvg.rst Co-authored-by: Bénédikt Tran <[email protected]>
There was an error while loading. Please reload this page.
…e-141770.JURnvg.rst Co-authored-by: Victor Stinner <[email protected]>
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <[email protected]>
There was an error while loading. Please reload this page.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Please can you check the buildbot failure? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
… used (pythongh-142079)" This reverts commit c4ccaf4.
There was an error while loading. Please reload this page.
|
I think it's a problem with the buildbot machine: it's timing out on other branches now, and the builds are taking nearly five hours, when they used to take around 50 minutes: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I just sent an email to David Bolen (the buildbot owner) to ask him to have a look. Something seems to be wrong with this buildbot worker. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This change introduced a regression: #142627. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Note for myself: The feature is not available on Fedora, since Fedora builds the Linux kernel without the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.