GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142163: Only define `HAVE_THREAD_LOCAL` when `Py_BUILD_CORE` is set by ZeroIntensity · Pull Request #142164 · python/cpython

Conversation

@ZeroIntensity

@ZeroIntensity ZeroIntensity commented Dec 1, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: python.h setting HAVE_THREAD_LOCAL breaks numpy build #142163

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ZeroIntensity added 3 commits December 1, 2025 18:15
@ZeroIntensity
Only define HAVE_THREAD_LOCAL when Py_BUILD_CORE is set.
9161899
@ZeroIntensity
Add blurb.
fe4fb52
@ZeroIntensity
Improve blurb.
2321c5a
@bedevere-app bedevere-app Bot mentioned this pull request Dec 1, 2025
python.h setting HAVE_THREAD_LOCAL breaks numpy build #142163
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 1, 2025
@ZeroIntensity

ZeroIntensity commented Dec 1, 2025

Copy link
Copy Markdown
Member Author

@ngoldbaum Would you mind verifying that this fixes NumPy?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity
ZeroIntensity requested a review from kumaraditya303 December 1, 2025 23:35
@ngoldbaum

ngoldbaum commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Seems to work:

Python 3.15.0a2+ (heads/fix-numpy-shenanigans:2321c5a, Dec  1 2025, 16:34:55) [Clang 17.0.0 (clang-1700.4.4.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import numpy
>>> numpy.__version__
'2.5.0.dev0+git20251201.fb0578d'
>>>
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tacaswell

tacaswell commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

lol, I like the branch name.

I can confirm that this fixes it for both

✘ 21:43:47 [belanna] @ clang++ --version
clang version 21.1.6
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
~
✔ 21:43:53 [belanna] @ g++ --version
g++ (GCC) 15.2.1 20251112
Copyright (C) 2025 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes Dec 2, 2025
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 2, 2025
@kumaraditya303
kumaraditya303 merged commit 4172885 into python:main Dec 2, 2025
52 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 2, 2025
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@ZeroIntensity @StanFromIreland
pythongh-142163: Only define HAVE_THREAD_LOCAL when Py_BUILD_CORE…
d216ed1 
… is set (python#142164)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ZeroIntensity @ngoldbaum @tacaswell @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.