GeezerVison is showing github.com — [3.14] gh-119452: Remove select, skip 'truncated' test by encukou · Pull Request #142178 · python/cpython
Conversation
encukou
commented
Dec 2, 2025
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
This removes the select added in commit 29c657a.
As Greg put it in https://github.com/python/cpython/pull/119455/files#r2580052775:
why select at all here given we just want to block on reading another chunk?
if the socket closes or errors, that'd return anyways.
This makes the function wait forever for the query body. Thus, the new test 'test_large_content_length_truncated' times out. This was the case before the fix, too.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This removes the select added in commit 29c657a.
As Greg put it in https://github.com/python/cpython/pull/119455/files#r2580052775:
> why select at all here given we just want to block on reading another chunk?
> if the socket closes or errors, that'd return anyways.
This makes the function wait forever for the query body.
Thus, the new test 'test_large_content_length_truncated' times out.
This was the case before the fix, too.
encukou
changed the title
gh-119452: Remove select, skip 'truncated' test
[3.14] gh-119452: Remove select, skip 'truncated' test
Dec 2, 2025
|
#142180 instead uses timeout for each iteration, if the user sets it
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Without timeout logic we cannot test that the fix actually works.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
gpshead
Awaiting requested review from gpshead
hugovk
Awaiting requested review from hugovk
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.