GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] Try to fix the fix for gh-119452 by serhiy-storchaka · Pull Request #142180 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Dec 2, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: OOM a potential denial of service in the CGI server on Windows #119452

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
[3.14] Try to fix the fix for pythongh-119452
f00ef9f
@bedevere-app bedevere-app Bot mentioned this pull request Dec 2, 2025
OOM a potential denial of service in the CGI server on Windows #119452
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 2, 2025
@serhiy-storchaka serhiy-storchaka added the skip news label Dec 2, 2025
@serhiy-storchaka
serhiy-storchaka marked this pull request as draft December 2, 2025 10:26
@bedevere-app bedevere-app Bot removed the awaiting core review label Dec 2, 2025
@serhiy-storchaka

serhiy-storchaka commented Dec 2, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64 Windows11 Non-Debug
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Dec 2, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit f00ef9f 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F142180%2Fmerge

The command will test the builders whose names match following regular expression: AMD64 Windows11 Non-Debug

The builders matched are:

  • AMD64 Windows11 Non-Debug PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou
encukou reviewed Dec 2, 2025
View reviewed changes
Comment thread Lib/http/server.py Outdated
while (len(data) < nbytes and len(data) != cursize and
cursize = min(nbytes, _MIN_READ_BUF_SIZE)
data = self.rfile.read(cursize)
while (len(data) == cursize < nbytes and

@encukou encukou Dec 2, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

len(data) == cursize means that we're expecting that cursize bytes of the data arrive over the socket simultaneously, right?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@serhiy-storchaka serhiy-storchaka Dec 2, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and this assumption was incorrect. There was another bug in the old code -- it did not work on Linux without fork(), because read(n) could return less than n bytes. #119455 fixed it, and we need to preserve this fix. I restored that code and try another approach -- using non-zero timeout.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
Simply use non-zero timeout.
769972c
@serhiy-storchaka
serhiy-storchaka marked this pull request as ready for review December 2, 2025 12:18
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 2, 2025
@encukou encukou mentioned this pull request Dec 2, 2025
[3.14] gh-119452: Remove select, skip 'truncated' test #142178
Closed
@serhiy-storchaka

serhiy-storchaka commented Dec 3, 2025

Copy link
Copy Markdown
Member Author

The old PR with this fix has been created as #142216.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka closed this Dec 3, 2025
@serhiy-storchaka
serhiy-storchaka deleted the http-server2 branch July 1, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @bedevere-bot @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.