GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-142145: Remove quadratic behavior in node ID cache clearing (GH-142146) by miss-islington · Pull Request #142210 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Dec 3, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Remove quadratic behavior in node ID cache clearing

Co-authored-by: Jacob Walls [email protected]

  • Add news fragment

(cherry picked from commit 08d8e18)

Co-authored-by: Seth Michael Larson [email protected]
Co-authored-by: Jacob Walls [email protected]

  • Issue: Remove quadratic behavior in node ID cache clearing #142145

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sethmlarson @jacobtylerwalls @miss-islington
pythongh-142145: Remove quadratic behavior in node ID cache clearing (p…
16104af 
…ythonGH-142146)

* Remove quadratic behavior in node ID cache clearing

Co-authored-by: Jacob Walls <[email protected]>

* Add news fragment

---------
(cherry picked from commit 08d8e18)

Co-authored-by: Seth Michael Larson <[email protected]>
Co-authored-by: Jacob Walls <[email protected]>
This was referenced Dec 3, 2025
Remove quadratic behavior in node ID cache clearing #142145
Closed
gh-142145: Remove quadratic behavior in node ID cache clearing #142146
Merged
@bedevere-app bedevere-app Bot added topic-XML type-security A security issue awaiting review labels Dec 3, 2025
@gpshead
gpshead enabled auto-merge (squash) December 3, 2025 07:17
@hugovk

hugovk commented Dec 5, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The Android failure is unrelated (some GitHub disk space issue).

But the WASI failure is in this PR's new test:

======================================================================
FAIL: testAppendChildNoQuadraticComplexity (test.test_minidom.MinidomTest.testAppendChildNoQuadraticComplexity)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Lib/test/test_minidom.py", line 192, in testAppendChildNoQuadraticComplexity
    self.assertLess(end - start, 1)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
AssertionError: 2.0126874446868896 not less than 1
----------------------------------------------------------------------
Ran 130 tests in 3.768s
FAILED (failures=1)
test test_minidom failed

@sethmlarson @gpshead
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk reviewed Dec 5, 2025
View reviewed changes
Comment thread Lib/test/test_minidom.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
Increase check to 10 seconds
445c888
@gpshead
gpshead merged commit ddcd2ac into python:3.13 Dec 5, 2025
73 of 75 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Dec 5, 2025
@vivian-rook vivian-rook mentioned this pull request Dec 9, 2025
fix(python-3.13): CVE-2025-12084 cherrypick fix wolfi-dev/os#75288
Merged
vivian-rook pushed a commit to wolfi-dev/advisories that referenced this pull request Dec 9, 2025
Vivian Rook
doc(python-3.1[0123]): Add pending-upstream-fix CVE-2025-12084
6e376b9 
python-3.10 Upstream Fix PR: python/cpython#142213
python-3.11 Upstream Fix PR: python/cpython#142212
python-3.12 Upstream Fix PR: python/cpython#142211
python-3.13 Upstream Fix PR: python/cpython#142210
python-3.13 Local Fix PR: wolfi-dev/os#75288
python-3.14 Upstream Fix PR: python/cpython#142209
python-3.14 Local Fix PR: wolfi-dev/os#75289

Related issues:
https://github.com/chainguard-dev/CVE-Dashboard/issues/50689
https://github.com/chainguard-dev/CVE-Dashboard/issues/51027
https://github.com/chainguard-dev/CVE-Dashboard/issues/50150
https://github.com/chainguard-dev/CVE-Dashboard/issues/51032
https://github.com/chainguard-dev/CVE-Dashboard/issues/50978

Signed-off-by: Vivian Rook <[email protected]>
@vivian-rook vivian-rook mentioned this pull request Dec 9, 2025
doc(python-3.1[012]): Add pending-upstream-fix CVE-2025-12084 wolfi-dev/advisories#27792
Merged
github-merge-queue Bot pushed a commit to wolfi-dev/advisories that referenced this pull request Dec 10, 2025
@vivian-rook
doc(python-3.1[0123]): Add pending-upstream-fix CVE-2025-12084 (#27792)
547952d 
python-3.10 Upstream Fix PR: python/cpython#142213
python-3.11 Upstream Fix PR: python/cpython#142212
python-3.12 Upstream Fix PR: python/cpython#142211
python-3.13 Upstream Fix PR: python/cpython#142210
python-3.13 Local Fix PR: wolfi-dev/os#75288
python-3.14 Upstream Fix PR: python/cpython#142209
python-3.14 Local Fix PR: wolfi-dev/os#75289

Related issues:
https://github.com/chainguard-dev/CVE-Dashboard/issues/50689
https://github.com/chainguard-dev/CVE-Dashboard/issues/51027
https://github.com/chainguard-dev/CVE-Dashboard/issues/50150
https://github.com/chainguard-dev/CVE-Dashboard/issues/51032
https://github.com/chainguard-dev/CVE-Dashboard/issues/50978

Signed-off-by: Vivian Rook <[email protected]>
Signed-off-by: Vivian Rook <[email protected]>
@gpshead gpshead mentioned this pull request Dec 20, 2025
gh-142145: relax the no-longer-quadratic test timing #143030
Merged
@miss-islington
miss-islington deleted the backport-08d8e18-3.13 branch January 2, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead left review comments
@hugovk hugovk hugovk left review comments
@Yhg1s Yhg1s Yhg1s left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-XML type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @hugovk @gpshead @Yhg1s @sethmlarson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.