GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142225: Fix `PyABIInfo_VAR` macro by StanFromIreland · Pull Request #142230 · python/cpython

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Dec 3, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
Include/modsupport.h:143:29: error: '_PyABIInfo_DEFAULT' undeclared here (not in a function); did you mean 'PyABIInfo_STABLE'?
  143 |     static PyABIInfo NAME = _PyABIInfo_DEFAULT;
      |                             ^~~~~~~~~~~~~~~~~~
/tmp/test.c:4:1: note: in expansion of macro 'PyABIInfo_VAR'
    4 | PyABIInfo_VAR(test_abi_info);
      | ^~~~~~~~~~~~~
  • Issue: Fix and test PyABIInfo_VAR #142225

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@StanFromIreland
Fix PyABIInfo_VAR macro
f5dac12
@StanFromIreland
StanFromIreland requested a review from encukou December 3, 2025 16:38
@StanFromIreland
StanFromIreland requested a review from ericsnowcurrently as a code owner December 3, 2025 16:38
@bedevere-app bedevere-app Bot mentioned this pull request Dec 3, 2025
Fix and test PyABIInfo_VAR #142225
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Dec 3, 2025
@encukou

encukou commented Dec 3, 2025

Copy link
Copy Markdown
Member

Thanks!
I noticed recently, but got caught up in writing tests/docs.
Let's get the fix in; tests will follow.

StanFromIreland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

encukou
encukou reviewed Dec 3, 2025
View reviewed changes
Comment thread Include/modsupport.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

@StanFromIreland
Remove parens instead
3443bc0
picnixz
picnixz reviewed Dec 3, 2025
View reviewed changes
Comment thread Include/modsupport.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

@StanFromIreland
Align slash
415799c
@encukou
encukou merged commit fb404ab into python:main Dec 4, 2025
46 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting review label Dec 4, 2025
@bedevere-bot

bedevere-bot commented Dec 4, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable 3.x (tier-3) has failed when building commit fb404ab.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1636/builds/1654) and take a look at the build logs.
  4. Check if the failure is related to this commit (fb404ab) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1636/builds/1654

Failed tests:

  • test_profiling

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/test/test_profiling/test_sampling_profiler/test_modes.py", line 163, in test_cpu_mode_integration_filtering
    with test_subprocess(cpu_vs_idle_script) as subproc:
         ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/contextlib.py", line 141, in __enter__
    return next(self.gen)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/test/test_profiling/test_sampling_profiler/helpers.py", line 85, in test_subprocess
    raise RuntimeError(
        f"Unexpected response from subprocess: {response!r}"
    )
RuntimeError: Unexpected response from subprocess: b'readythreads_ready'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@StanFromIreland
StanFromIreland deleted the fix-PyABIInfo_VAR branch December 4, 2025 13:21
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@StanFromIreland
pythongh-142225: Fix PyABIInfo_VAR macro (pythonGH-142230)
18be0c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@picnixz picnixz picnixz left review comments
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@StanFromIreland @encukou @bedevere-bot @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.