GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-140683: JIT: Improve machine code for loading smaller constants on AArch64. by markshannon · Pull Request #142511 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Dec 10, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Use movz and movk instructions for loading 16 and 32 bit operands and oparg.
  • Loading of 64 bit operands is unchanged.
  • Issue: The code generated by the JIT for loading 16 bit and 32 bit constants is inefficient. #140683

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
JIT: Improve machine code for loading smaller constants on AArch64.
8110012 
* Use movz and movk instructions for loading 16 and 32 bit operands and oparg.
* Loading of 64 bit operands is unchanged.
@markshannon
markshannon requested review from brandtbucher, diegorusso and savannahostrowski as code owners December 10, 2025 11:48
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 10, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 10, 2025
The code generated by the JIT for loading 16 bit and 32 bit constants is inefficient. #140683
Closed
@markshannon
Update constant names for 32 bit builds
abcd82c
@markshannon markshannon added the skip news label Dec 10, 2025
markshannon added 2 commits December 10, 2025 16:55
@markshannon
Merge branch 'main' into optimize-consts-16-and-32
15ea98a
@markshannon
Merge branch 'main' into optimize-consts-16-and-32
1486851
diegorusso
diegorusso approved these changes Dec 11, 2025
View reviewed changes

@diegorusso diegorusso left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've discussed at depth with Mark about this change before creating the PR. LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 11, 2025
@markshannon
markshannon merged commit 4eab90f into python:main Dec 11, 2025
80 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 11, 2025
fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 12, 2025
@markshannon @fatelei
pythonGH-140683: JIT: Improve machine code for loading smaller consta…
cc13eb0 
…nts on AArch64. (pythonGH-142511)

* Use movz and movk instructions for loading 16 and 32 bit operands and oparg.
* Loading of 64 bit operands is unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegorusso diegorusso diegorusso approved these changes
@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@markshannon @diegorusso
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.