GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-134584: Revert partially #135860 by Fidget-Spinner · Pull Request #142620 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Dec 12, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This fixes a refleak.

  • Issue: Eliminate redundant refcounting in the JIT #134584

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fidget-Spinner
Revert partially python#135860
e2f0de3
@Fidget-Spinner
Fidget-Spinner requested review from markshannon and tomasr8 as code owners December 12, 2025 09:31
@bedevere-app bedevere-app Bot mentioned this pull request Dec 12, 2025
Eliminate redundant refcounting in the JIT #134584
Closed
35 tasks done
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 12, 2025
@Fidget-Spinner Fidget-Spinner added the skip news label Dec 12, 2025
@Fidget-Spinner
remove unused label
c7df8fb
@Zheaoli

Zheaoli commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

Should I change #136070 to avoid the refleak?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Dec 12, 2025
gh-134584: Eliminate redundant refcounting from _CALL_TUPLE_1 #135860
Merged
vstinner
vstinner approved these changes Dec 12, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: I confirm that this change fix the refleak. I didn't review the change itself, it just looks good to me :-)

$ ./python -m test test.test_multiprocessing_fork.test_threads -R 3:3 
(...)
Result: SUCCESS

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 12, 2025
@Fidget-Spinner

Fidget-Spinner commented Dec 12, 2025

Copy link
Copy Markdown
Member Author

Should I change #136070 to avoid the refleak?

The PR can't be fixed/ the code generator won't allow the change until #142604 is merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Fidget-Spinner merged commit a3a611b into python:main Dec 12, 2025
72 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 12, 2025
@Fidget-Spinner
Fidget-Spinner deleted the partial_revert_135860 branch December 12, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Fidget-Spinner @Zheaoli @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.