GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-134584: Eliminate redundant refcounting from `_CALL_STR_1` by Zheaoli · Pull Request #136070 · python/cpython

Conversation

@Zheaoli

@Zheaoli Zheaoli commented Jun 28, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Eliminate redundant refcounting in the JIT #134584

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Zheaoli
pythongh-134584: Eliminate redundant refcounting from _CALL_STR_1
81cd4f4 
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli
Zheaoli requested review from Fidget-Spinner, markshannon and tomasr8 as code owners June 28, 2025 09:55
@bedevere-app bedevere-app Bot added the awaiting review label Jun 28, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 28, 2025
Eliminate redundant refcounting in the JIT #134584
Closed
35 tasks done
@Zheaoli
fix ci
a8057aa 
Signed-off-by: Manjusaka <[email protected]>
@Fidget-Spinner

Fidget-Spinner commented Jun 28, 2025

Copy link
Copy Markdown
Member

Thanks! This looks great to me. Just waiting for Mark's PR on TOS caching to get merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner
Fidget-Spinner reviewed Dec 11, 2025
View reviewed changes
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Zheaoli added 2 commits December 11, 2025 23:35
@Zheaoli
fix review idea
5636c72 
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli
merge main
53cef9d 
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli
Zheaoli requested a review from Fidget-Spinner December 12, 2025 08:01
@Zheaoli Zheaoli mentioned this pull request Dec 12, 2025
gh-134584: Revert partially #135860 #142620
Merged
Fidget-Spinner
Fidget-Spinner reviewed Dec 13, 2025
View reviewed changes
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Zheaoli added 2 commits December 14, 2025 16:43
@Zheaoli
Merge branch 'main' of https://github.com/python/cpython into manjusa…
98aaa63 
…ka/refcount-call-str
@Zheaoli
fix review idea
2dcd9eb 
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli

Zheaoli commented Dec 14, 2025

Copy link
Copy Markdown
Contributor Author

@Fidget-Spinner Thanks for your time, I have update the PR like what we do in #142604

BTW just for personal interest, May I ask why we revert the code generator change in #142604 ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner
Fidget-Spinner approved these changes Dec 14, 2025
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This is great!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 14, 2025
@Fidget-Spinner

Fidget-Spinner commented Dec 14, 2025

Copy link
Copy Markdown
Member

BTW just for personal interest, May I ask why we revert the code generator change in #142604 ?

I realised we can get the same thing with ERROR_NO_POP, so there's no point to do it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Fidget-Spinner merged commit a154c9e into python:main Dec 14, 2025
74 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 14, 2025
@Zheaoli

Zheaoli commented Dec 14, 2025

Copy link
Copy Markdown
Contributor Author

I realised we can get the same thing with ERROR_NO_POP, so there's no point to do it.

Got it! Thanks your time!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Zheaoli
Zheaoli deleted the manjusaka/refcount-call-str branch December 14, 2025 09:35
fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 16, 2025
@Zheaoli @fatelei
pythongh-134584: Eliminate redundant refcounting from _CALL_STR_1 (p…
8203fe0 
…ythonGH-136070)

Signed-off-by: Manjusaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Zheaoli @Fidget-Spinner @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.