GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-138122: Improve bytecode panel by ivonastojanovic · Pull Request #142910 · python/cpython

Conversation

@ivonastojanovic

@ivonastojanovic ivonastojanovic commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

The bytecode panel appears when a user generates a heatmap with --opcodes and clicks the button to unfold a line and display the bytecode instructions. Currently, an empty space appears on the left where the line number, self, and total columns are displayed. This area should instead extend those columns, rather than leaving a gap.

Before:

Screen.Recording.2025-12-18.at.00.08.34.mov

Now:

Screen.Recording.2025-12-18.at.00.03.09.mov
  • Issue: Implement PEP 799 – A dedicated profiling package for organizing Python profiling tools #138122

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ivonastojanovic
Improve bytecode panel
b950bc4 
The bytecode panel appears when a user generates a heatmap with
--opcodes and clicks the button to unfold a line and display the
bytecode instructions. Currently, an empty space appears on the
left where the line number, self, and total columns are displayed.
This area should instead extend those columns, rather than leaving
a gap.
@ivonastojanovic
ivonastojanovic requested a review from pablogsal as a code owner December 18, 2025 00:09
@bedevere-app bedevere-app Bot mentioned this pull request Dec 18, 2025
Implement PEP 799 – A dedicated profiling package for organizing Python profiling tools #138122
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Dec 18, 2025
@ivonastojanovic ivonastojanovic added skip news and removed awaiting review labels Dec 18, 2025
@pablogsal

pablogsal commented Dec 18, 2025

Copy link
Copy Markdown
Member

@lkollar @hugovk @savannahostrowski @StanFromIreland @AA-Turner I am curious what you think about this UX. @ivonastojanovic and myself were discussing how this should look. I particularly like that when you click the arrow it looks like the source line "unfolds" and shows the bytecode internals but the original versions is too wide and the data is too spread around. On the other hand this looks "more" like a popup. What do you folks think?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes Dec 18, 2025
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks better 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting merge label Dec 18, 2025
lkollar
lkollar approved these changes Dec 18, 2025
View reviewed changes
pablogsal
pablogsal approved these changes Dec 18, 2025
View reviewed changes
@pablogsal
pablogsal merged commit cbc0851 into python:main Dec 18, 2025
52 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 18, 2025
@pablogsal

pablogsal commented Dec 18, 2025

Copy link
Copy Markdown
Member

Amazing 👌
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cocolato pushed a commit to cocolato/cpython that referenced this pull request Dec 18, 2025
@ivonastojanovic @cocolato
pythongh-138122: Improve bytecode panel (python#142910)
6dcd7ac 
The bytecode panel appears when a user generates a heatmap with
--opcodes and clicks the button to unfold a line and display the
bytecode instructions. Currently, an empty space appears on the
left where the line number, self, and total columns are displayed.
This area should instead extend those columns, rather than leaving
a gap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@pablogsal pablogsal pablogsal approved these changes
+1 more reviewer
@lkollar lkollar lkollar approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ivonastojanovic @pablogsal @lkollar @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.