GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — gh-142927: Tachyon: Comma separate thousands and fix singular/plurals by hugovk · Pull Request #142934 · python/cpython Conversation
|
|
I'd like to suggest using a locale translation for separating numbers instead of using english-based values. I am personally always confused when commas are used to separate thousands and I think it's better if it's using a localized output. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I disagree with the "Single file specialisation," IMO the plural sounds better and in general zero takes a plural noun form? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Right now, the numbers are formatted in the Python script, and then put into the HTML. I guess one way would be to put unformatted numbers in the HTML and use some JS to do locale conversion in the browser? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
"x/y" is like saying "x of y", and it's the "y" that matters for the plural:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Can't we use localized messages? or maybe pass through locale.(...) for formatting numbers? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Yes, and that's much simpler :) How does this 9cfd9ef look? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It looks better (and simpler). For the "words" we can also use |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'll let you open a followup if you'd like to localise the words :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.