GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142927: Tachyon: Fix singular and plurals by hugovk · Pull Request #145329 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Feb 27, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Some more like #142934, spotted some of these can be 1 in #145306 (comment).

  • Issue: Improve Tachyon UX #142927

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Tachyon: Fix singular and plurals
b33521e
@hugovk
hugovk requested a review from pablogsal as a code owner February 27, 2026 18:18
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 27, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Feb 27, 2026
Improve Tachyon UX #142927
Open
11 tasks done
hugovk
hugovk commented Feb 27, 2026
View reviewed changes
Comment thread Lib/profiling/sampling/stack_collector.py
Comment on lines +151 to +153
f"Flamegraph data: {num_functions} root function{s1}, "
f"{total_time} total sample{s2}, "
f"{string_count} unique string{s3}"

@hugovk hugovk Feb 27, 2026

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was:

Flamegraph data: X root functions, total samples: Y, Z unique strings

I also changed the order of the middle one for consistency:

Flamegraph data: X root functions, Y total samples, Z unique strings

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk hugovk added the skip news label Feb 27, 2026
pablogsal
pablogsal approved these changes Feb 27, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 27, 2026
@pablogsal

pablogsal commented Feb 27, 2026

Copy link
Copy Markdown
Member

Thanks @hugovk
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit 2e2109d into python:main Feb 28, 2026
53 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 28, 2026
@hugovk
hugovk deleted the 3.15-tachyon-plurals branch February 28, 2026 07:19
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
@hugovk @brijkapadia
pythongh-142927: Tachyon: Fix singular and plurals (python#145329)
e916488
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@hugovk @ljfp
pythongh-142927: Tachyon: Fix singular and plurals (python#145329)
7ba9e6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.