GeezerVison is showing github.com — gh-142927: Tachyon: Fix contrast ratio in top panel by hugovk · Pull Request #142936 · python/cpython
Conversation
hugovk
commented
Dec 18, 2025
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Before
In dark mode, the samples/sec numbers has contrast ratio of 2.9.
In light mode, duration and missed samples are 1.63 and 2.15 respectively.
They should be at least 4.5 to meet WCAG AA guidelines.
After
The values suggested by Chrome:
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
This also affects the flamegraph output.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This also affects the flamegraph output.
In what way? For better, or worse? Please share more details.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
As in, the CSS is copy-pasted:
|
.summary-card:nth-child(1) { --i: 0; --card-color: 55, 118, 171; } |
|
.summary-card:nth-child(2) { --i: 1; --card-color: 40, 167, 69; } |
|
.summary-card:nth-child(3) { --i: 2; --card-color: 255, 193, 7; } |
|
.summary-card:nth-child(4) { --i: 3; --card-color: 111, 66, 193; } |
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Ah right, thanks. Let's update those too.
They should be at least 4.5 to meet WCAG AA guidelines.
Actually, that's for normal size text. The heatmap panel is large, so the original colours are at least 3.
We need 4.5 for the flamegraph, and it's hard to find colours that work for both dark and light themes. So this is now updated to different colour for dark/light and re-use via variables.
Also we don't need stat-card for 5th and 6th children, rate-card is used instead. So delete that dead code.
Heatmap:
Flamegraph:

|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
hugovk reacted with rocket emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|