GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142927: Tachyon: Fix contrast ratio in top panel by hugovk · Pull Request #142936 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Dec 18, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Before

In dark mode, the samples/sec numbers has contrast ratio of 2.9.

In light mode, duration and missed samples are 1.63 and 2.15 respectively.

They should be at least 4.5 to meet WCAG AA guidelines.

image image

After

The values suggested by Chrome:

image image
  • Issue: Improve Tachyon UX #142927

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
hugovk added 2 commits December 18, 2025 16:01
@hugovk
Fix contrast for samples/sec with dark theme
c5bd63c
@hugovk
Fix contrast for duration and missed samples with light theme
ccdfab0
@hugovk
hugovk requested a review from pablogsal as a code owner December 18, 2025 14:10
@hugovk hugovk added the skip news label Dec 18, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 18, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 18, 2025
Improve Tachyon UX #142927
Open
11 tasks done
pablogsal
pablogsal approved these changes Dec 18, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 18, 2025
@pablogsal

pablogsal commented Dec 18, 2025

Copy link
Copy Markdown
Member

Thanks a lot @hugovk 🖤

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@StanFromIreland

StanFromIreland commented Dec 18, 2025

Copy link
Copy Markdown
Member

This also affects the flamegraph output.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented Dec 18, 2025

Copy link
Copy Markdown
Member Author

This also affects the flamegraph output.

In what way? For better, or worse? Please share more details.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@StanFromIreland

StanFromIreland commented Dec 18, 2025

Copy link
Copy Markdown
Member

As in, the CSS is copy-pasted:

cpython/Lib/profiling/sampling/_flamegraph_assets/flamegraph.css

Lines 349 to 352 in 14f0b51

.summary-card:nth-child(1) { --i: 0; --card-color: 55, 118, 171; }
.summary-card:nth-child(2) { --i: 1; --card-color: 40, 167, 69; }
.summary-card:nth-child(3) { --i: 2; --card-color: 255, 193, 7; }
.summary-card:nth-child(4) { --i: 3; --card-color: 111, 66, 193; }

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk
Update with variables for both light and dark
0846506
@hugovk

hugovk commented Dec 22, 2025

Copy link
Copy Markdown
Member Author

Ah right, thanks. Let's update those too.

They should be at least 4.5 to meet WCAG AA guidelines.

Actually, that's for normal size text. The heatmap panel is large, so the original colours are at least 3.

We need 4.5 for the flamegraph, and it's hard to find colours that work for both dark and light themes. So this is now updated to different colour for dark/light and re-use via variables.

Also we don't need stat-card for 5th and 6th children, rate-card is used instead. So delete that dead code.

Heatmap:

image image

Flamegraph:

image image

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal
pablogsal merged commit ea3fd78 into python:main Dec 25, 2025
44 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 25, 2025
@pablogsal

pablogsal commented Dec 25, 2025

Copy link
Copy Markdown
Member

Thanks a lot @hugovk and @StanFromIreland !

hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk
hugovk deleted the 3.15-tachyon-contrast branch December 26, 2025 10:19
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@hugovk @thunder-coding
pythongh-142927: Tachyon: Fix contrast ratio in top panel (python#142936
1a03280
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @pablogsal @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.