GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142927: Tachyon: Start with user's default light/dark theme by hugovk · Pull Request #142987 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Dec 19, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Right now, the page always starts in light mode, even if I have my system set to dark.

Instead, let's check prefers-color-scheme for the initial theme.

And if the user changes it, continue to save that preference in local storage.

Finally, refactor common theme support into heatmap_shared.js.

  • Issue: Improve Tachyon UX #142927

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk added 2 commits December 19, 2025 19:18
@hugovk
Start with user's default light/dark theme
e501054
@hugovk
Refactor common theme support into heatmap_shared.js
9f81f2d
@hugovk
hugovk requested a review from pablogsal as a code owner December 19, 2025 17:18
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 19, 2025
@hugovk hugovk added skip news and removed awaiting core review labels Dec 19, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 19, 2025
Improve Tachyon UX #142927
Open
11 tasks done
pablogsal
pablogsal approved these changes Dec 20, 2025
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Thanks you @hugovk !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@bedevere-app bedevere-app Bot added the awaiting merge label Dec 20, 2025
@pablogsal
pablogsal merged commit 5b52636 into python:main Dec 20, 2025
52 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 20, 2025
@hugovk
hugovk deleted the 3.15-tachyon-browser-default-dark-light branch December 20, 2025 05:08
cocolato pushed a commit to cocolato/cpython that referenced this pull request Dec 22, 2025
@hugovk @cocolato
pythongh-142927: Tachyon: Start with user's default light/dark theme (p…
c132658 
…ython#142987)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.