GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-130796: Undeprecate locale.getdefaultlocale() by vstinner · Pull Request #143069 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Dec 22, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Deprecation of locale.getdefaultlocale breaks POSIX compatibility on Windows platform #130796

📚 Documentation preview 📚: https://cpython-previews--143069.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-130796: Undeprecate locale.getdefaultlocale()
499596c
@vstinner vstinner added the skip news label Dec 22, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 22, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 22, 2025
Deprecation of locale.getdefaultlocale breaks POSIX compatibility on Windows platform #130796
Closed
@vstinner
Remove unused import
dd4516a
@hugovk

hugovk commented Dec 22, 2025

Copy link
Copy Markdown
Member

Should we note the undeprecation in What's New?

Let's also remove/update in Doc/deprecations/pending-removal-in-3.15.rst
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland

StanFromIreland commented Dec 22, 2025

Copy link
Copy Markdown
Member

I think adding a news entry makes sense, it may cause confusion now when one searches the changelog, and sees it is deprecated with no un-deprecation note.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added 2 commits December 23, 2025 11:43
@vstinner
Add NEWS entry
bca57e7 
Update Doc/deprecations/pending-removal-in-3.15.rst.
@vstinner
Add What's New entry
7e36d09
@vstinner
vstinner requested a review from AA-Turner as a code owner December 23, 2025 10:45
@vstinner

vstinner commented Dec 23, 2025

Copy link
Copy Markdown
Member Author

@hugovk @StanFromIreland: I added What's New and NEWS entries. Please review the updated change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes Dec 23, 2025
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 23, 2025
StanFromIreland
StanFromIreland approved these changes Dec 23, 2025
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner merged commit 6536fab into python:main Dec 23, 2025
87 of 89 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the undeprecate_getdefaultlocale branch December 23, 2025 15:31
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 23, 2025
This was referenced Jun 11, 2026
Remove deprecated function locale.getdefaultlocale #134086
Closed
Deprecate locale.getdefaultlocale() function #90817
Closed
@hugovk

hugovk commented Jun 11, 2026

Copy link
Copy Markdown
Member

Re: #90817 (comment), let's backport.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jun 11, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6536fab19410ce701575b553d381cf805d3ef323 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned vstinner Jun 11, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6536fab19410ce701575b553d381cf805d3ef323 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151317 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 11, 2026
@bedevere-app

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151318 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 11, 2026
hugovk added a commit that referenced this pull request Jun 11, 2026
@hugovk @vstinner
[3.14] gh-130796: Undeprecate locale.getdefaultlocale() (GH-143069) (#…
58c6e78 
…151317)

Co-authored-by: Victor Stinner <[email protected]>
hugovk added a commit that referenced this pull request Jun 11, 2026
@hugovk @vstinner
[3.13] gh-130796: Undeprecate locale.getdefaultlocale() (GH-143069) (#…
06dce35 
…151318)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@StanFromIreland StanFromIreland StanFromIreland approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @hugovk @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.