GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-142513: fix missing return in executor_clear by chris-eibl · Pull Request #143073 · python/cpython

Conversation

@chris-eibl

@chris-eibl chris-eibl commented Dec 22, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes also the warnings like

C:\a\cpython\cpython\Python\optimizer.c(1776): warning C4716: 'executor_clear': must return a value

seen in CI, e.g. https://github.com/python/cpython/actions/runs/20434930925/job/58714738349?pr=143068.

  • Issue: Executor management code lacks proper invariants leading to bugs. #142513

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chris-eibl
fix missing return in executor_clear
9e21085
@chris-eibl
chris-eibl requested review from Fidget-Spinner and markshannon as code owners December 22, 2025 16:17
@bedevere-app bedevere-app Bot added the awaiting review label Dec 22, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 22, 2025
Executor management code lacks proper invariants leading to bugs. #142513
Closed
@chris-eibl chris-eibl mentioned this pull request Dec 22, 2025
gh-142476: Fix Windows crashing with JIT #143021
Merged
@chris-eibl chris-eibl added the skip news label Dec 22, 2025
@chris-eibl chris-eibl mentioned this pull request Dec 22, 2025
GH-139922: Tail calling for MSVC (VS 2026) #143068
Merged
@chris-eibl

chris-eibl commented Dec 22, 2025

Copy link
Copy Markdown
Member Author

Ups, jit CI still flaky :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Fidget-Spinner merged commit 700e9fa into python:main Dec 22, 2025
64 of 66 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Dec 22, 2025
@chris-eibl
chris-eibl deleted the fix-executor_clear-ret-val branch December 22, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@chris-eibl @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.