GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142476: Fix Windows crashing with JIT by Fidget-Spinner · Pull Request #143021 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Dec 20, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This happened after #143021

  • Issue: ASan memory leak in test_gc with --enable-experimental-jit (allocate_executor) #142476

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fidget-Spinner
Fix Windows crashing with JIT
f1c3eee
@Fidget-Spinner
Fidget-Spinner requested a review from markshannon as a code owner December 20, 2025 13:19
@bedevere-app bedevere-app Bot mentioned this pull request Dec 20, 2025
ASan memory leak in test_gc with --enable-experimental-jit (allocate_executor) #142476
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 20, 2025
@Fidget-Spinner Fidget-Spinner added skip news and removed awaiting core review labels Dec 20, 2025
@Fidget-Spinner
Fidget-Spinner merged commit 9ded3dd into python:main Dec 22, 2025
68 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Fidget-Spinner deleted the fix_refleak_path_jit branch December 22, 2025 14:57
@Fidget-Spinner

Fidget-Spinner commented Dec 22, 2025

Copy link
Copy Markdown
Member Author

I merged as it's a trivial change and more of a bugfix on top of the previous PR by the contributor that I didn't catch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chris-eibl

chris-eibl commented Dec 22, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Maybe related:

C:\a\cpython\cpython\Python\optimizer.c(1776): warning C4716: 'executor_clear': must return a value [C:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

cpython/Python/optimizer.c

Lines 1772 to 1776 in e728b00

static int
executor_clear(PyObject *op)
{
executor_invalidate(op);
}

PR: #143073
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Fidget-Spinner @chris-eibl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.